Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editorial] - [4e8ab6] Element with role attribute has required states and properties - Inapplicable Example 2 improvement (acc name) #2265

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

giacomo-petri
Copy link
Collaborator

Closes issue(s): #2264

Description:

This PR adds the required acc name to the checkbox element
from
<input type="checkbox" role="checkbox" />
to
<input type="checkbox" role="checkbox" aria-label="Checkbox name"/>

Need for Call for Review:

This can be merged with 1 approval

@giacomo-petri giacomo-petri added the Editorial For editorial changes that does not change the meaning of a rule or Glossary term label Feb 1, 2025
@Jym77
Copy link
Collaborator

Jym77 commented Feb 6, 2025

Closes issue(s): #2264

I understand from Github help that you have to write it as closes #XXXX to trigger the automation (and auto close the issue when the PR is merged)
(seems to affect your other PRs)

@Jym77
Copy link
Collaborator

Jym77 commented Feb 6, 2025

Need for Call for Review:

This can be merged with 1 approval

I'm also not sure about the review call. As per our guidelines in the PR template, changes to examples always require a 1 week Call for Review (since there may be some unwanted effect that we miss).

Jym77
Jym77 previously approved these changes Feb 6, 2025
@Jym77 Jym77 dismissed their stale review February 20, 2025 13:01

Duplicate organisation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editorial For editorial changes that does not change the meaning of a rule or Glossary term reviewers wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants