Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary autocomplete support item #2284

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

WilcoFiers
Copy link
Member

Noticed this one reviewing our support items. This looks like it might have been added by some misunderstanding on our part, not something that was a problem in browsers.

The issue here related to form elements with autocomplete=off, but as far as I can tell that does not result in elm.autocomplete === '' when the autocomplete is otherwise set.

Need for Call for Review: none, small change

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Noticed this one reviewing our support items. This looks like it might have been added by some misunderstanding on our part, not something that was a problem in browsers.

The issue here related to form elements with autocomplete=off, but as far as I can tell that does not result in `elm.autocomplete === ''` when the autocomplete is otherwise set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants