[23a2a8] Image has non-empty accessible name - Removes Inapplicable Example 1 and adds accessibility support note to cover SVG role exposed differently by browsers #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomo-petri
requested review from
WilcoFiers,
iadawn,
carlosapaduarte,
dd8,
tombrunet,
Jym77,
kengdoj,
HelenBurge,
daniel-montalvo and
dan-tripp-siteimprove
|
I've just realised there is one more rule affected by this. I'm adding the file to have everything in one go |
iadawn
approved these changes
Feb 7, 2025
Co-authored-by: Kevin White <[email protected]>
|
We can move forward with the review, since the related issue requires necessarily another issue and PR. |
WilcoFiers
approved these changes
Feb 13, 2025
giacomo-petri
commented
Feb 13, 2025
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
giacomo-petri
commented
Feb 13, 2025
dan-tripp-siteimprove
approved these changes
Feb 13, 2025
|
Call for review ends on February 28th 2025. |
giacomo-petri
added
Review call 2 weeks
shunguoy
approved these changes
Feb 13, 2025
Jym77
approved these changes
Feb 14, 2025
carlosapaduarte
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2241
This PR is intended to address how browsers are differently exposing SVG elements.
Changes:
Need for Call for Review:
This will require a 2 weeks Call for Review