Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated required owned elms rule description #2305

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

WilcoFiers
Copy link
Member

When reviewing this rule I noticed the description is out of sync with what it actually requires.

Need for Call for Review: none


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not approving since Dan already did.

Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for act-rules failed.

Name Link
🔨 Latest commit 78b777e
🔍 Latest deploy log https://app.netlify.com/sites/act-rules/deploys/67b746b5ceba1f0008ec1b95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants