Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Empty "Scanned Files" and "OpenSSF Scorecard" sections if no issues found #863

Open
fabasoad opened this issue Jan 17, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@fabasoad
Copy link

Describe the bug
There is a table with headers only and empty "Scanned Files" section in Action Summary view in case no vulnerabilities and OpenSSF Scorecard issues found.

To Reproduce
Steps to reproduce the behavior:

  1. Run the action on the project with no issues.
  2. Go to Actions > Select run
  3. Scroll to the summary view at the bottom

Expected behavior

Dependency Review
✅ No vulnerabilities or OpenSSF Scorecard issues found.

* without "Scanned Files" and "OpenSSF Scorecard" empty sections

Screenshots

Image

Action version
Latest at the moment - v4.5.0

Examples
None.

Additional context
This is not a critical neither a blocking issue, but:

  1. It is a little bit confusing to see nothing in "Scanned Files". The first thought is - "Maybe nothing were scanned and that's why it reports that no vulnerabilities are found? How can I make it to perform the actual scan?" 🤔 To avoid confusion either there should be a list of scanned files despite of the result, or simply remove "Scanned Files" section as well as remove "OpenSSF Scorecard" section for the same reason - it is empty and confusing that might be nothing was checked.
  2. Visually it is prettier to see a single sentence that nothing was found without a noise as empty tables and empty sections.
@fabasoad fabasoad added the bug Something isn't working label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant