Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action continues marking PRs as stale, although it should not do it #1071

Closed
2 of 5 tasks
dartcafe opened this issue Aug 8, 2023 · 3 comments
Closed
2 of 5 tasks
Assignees
Labels
bug Something isn't working

Comments

@dartcafe
Copy link

dartcafe commented Aug 8, 2023

Description:
PRs get marked as stale and closed, but they should be ignored, as configured.

Example: nextcloud/polls#2928

The action seems to recognize the exempt-labels and judging from the log, the PR is skipped, but nevertheless the stale label got added. Additionally, this PR is a draft and also should get ignored because of this.

I can't identify any misconfiguration.

Action version:
v8

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:
See PRs here: https://github.com/nextcloud/polls/pulls
Action file: https://github.com/nextcloud/polls/blob/master/.github/workflows/stale.yml
Todays action log: https://github.com/nextcloud/polls/actions/runs/5791954264/job/15697526998

Expected behavior:
The PRs should not be marked as stale as defined in the action config

Actual behavior:
PRs without any action in the last days get marked as stale and also get closed on a regulary basis although they should be skipped.

@dartcafe dartcafe added bug Something isn't working needs triage labels Aug 8, 2023
@dsame dsame removed the needs triage label Aug 8, 2023
@dsame
Copy link
Contributor

dsame commented Aug 8, 2023

Hello @dartcafe , thank you for you input. We are starting to investigate the issue

@dsame dsame self-assigned this Aug 8, 2023
@dsame
Copy link
Contributor

dsame commented Aug 9, 2023

Hello @dartcafe , it seems the PR is closed by another stale workflow https://github.com/nextcloud/polls/blob/master/.github/workflows/missing_template.yml

Can you please disable it and check if problem exists?

@dartcafe
Copy link
Author

dartcafe commented Aug 9, 2023

Ehm. Yes. What can I say? 🙈
OMFG, Thanks and sorry. I really didn't see that action. Thanks a lot!!!

@dartcafe dartcafe closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants