Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close-issue-reason not working. everything closes as completed #1107

Open
snehara99 opened this issue Nov 3, 2023 · 3 comments
Open

close-issue-reason not working. everything closes as completed #1107

snehara99 opened this issue Nov 3, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@snehara99
Copy link

Description:
The close-issue-reason (options: not_planned or completed) isn't working. It seems that close-issue-reason isn't being recognized. The default is supposed to be not_planned but whether we specify not_planned or leave it out, all the issues are closing as completed.

Action version:
actions/[email protected]

Platform:
Windows

Runner type:
Hosted

Repro steps:
workflow file
We have also tried leaving out the setting, as not_planned should be default, but it still closes as completed.

Expected behavior:
I expect the issues to close as not_planned.

Actual behavior:
Issues are closing as completed.

@snehara99 snehara99 added bug Something isn't working needs triage labels Nov 3, 2023
@nikolai-laevskii
Copy link
Contributor

Thank you for creating the issue! We will investigate and come back with the details.

@rcomer
Copy link

rcomer commented Jan 4, 2024

I think you just need to update the version of the action you are using. The option was only added at v5.1 and your logs show close-issue-reason as an unexpected input.

@onionhammer
Copy link

"completed" should not be the default behavior of this bot. Full stop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants