Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions fails if rate Limit is not enabled #1156

Open
ggabijaa opened this issue Apr 27, 2024 · 3 comments
Open

Actions fails if rate Limit is not enabled #1156

ggabijaa opened this issue Apr 27, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@ggabijaa
Copy link

ggabijaa commented Apr 27, 2024

Description:
When running action on schedule errors due to rateLimit. The actions is marked as successful but logs were showing errors:
image

Is this expected behavior? Should action error out when rateLimit, not enabled?

Action version: V9

Platform: Rocky Linux

Runner type: Self-hosted

Workfkow config:

name: Mark Stale Pull Requests

on:
  schedule:
    - cron: '0 1 * * *'

permissions:
  issues: write
  pull-requests: write


jobs:
  stale:
    runs-on: [self-hosted, rocky]
    steps:
      - uses: actions/stale@v9
        with:
          days-before-stale: 3
          stale-pr-label: 'stale'
          labels-to-remove-when-unstale: 'stale'
          days-before-close: -1
@ggabijaa ggabijaa added bug Something isn't working needs triage labels Apr 27, 2024
@HarithaVattikuti
Copy link
Contributor

Hello @ggabijaa
Thank you for creating this issue. We will investigate it and get back to you as soon as we have some feedback.

@martin-majlis-s1
Copy link

When I check the documentation - https://docs.github.com/en/[email protected]/admin/configuring-settings/configuring-user-applications-for-your-enterprise/configuring-rate-limits#about-rate-limits-for-github-actions - I can see, that it says:

By default, the rate limit for GitHub Actions is disabled. Because GitHub Enterprise Server can handle temporary spikes in usage without performance degradation, this rate limit is intended to protect against sustained high load. We recommend leaving the rate limit disabled unless you are experiencing performance problems. In some cases, GitHub Support may recommend that you enable a rate limit for GitHub Actions.

Not having a rate limit is expected state and it should not be logged as an error - https://github.com/actions/stale/blob/main/src/classes/issues-processor.ts#L648

What do you think?

@nunosousa-dev
Copy link

Is this still being analyzed? At least a flag to not check for rate limites could be considered, or just remove this error print for GH Enterprise instances. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants