Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should scan starting with oldest PR rather than newest PR #974

Closed
2 of 5 tasks
msorens opened this issue Mar 29, 2023 · 3 comments
Closed
2 of 5 tasks

Should scan starting with oldest PR rather than newest PR #974

msorens opened this issue Mar 29, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@msorens
Copy link

msorens commented Mar 29, 2023

Description:
When setting up this stale action in a workflow for the first time in a repo with a lot of PRs and a lot of them stale, the scan should start at the oldest one rather than the newest one. Or at least provide an option to do this. In one repo we have a lot of PRs that would meet the "stale" criteria—more than would be processed in a single run. So I and my coworkers were very surprised that the first run tagged the newest batch of PRs.

Action version:
v8

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:
Have a repo with many dozens of stale PRs such that a single run of stale will only tag a portion of them.

Expected behavior:
The oldest PRs should be tagged by stale.

Actual behavior:
The newest PRs are tagged by stale.

@msorens msorens added bug Something isn't working needs triage labels Mar 29, 2023
@msorens msorens changed the title Should scan from starting with oldest PR rather than newest PR Should scan starting with oldest PR rather than newest PR Mar 29, 2023
@MAGICCC
Copy link

MAGICCC commented Mar 29, 2023

You can set ascending: "true"
https://github.com/actions/stale#ascending

Can be argued that the maintainers of the action can change the default behavoir of ascending

@msorens
Copy link
Author

msorens commented Mar 29, 2023

Ah, I missed that option. Having it available is all I need. Thanks!

@msorens msorens closed this as completed Mar 29, 2023
@marko-zivic-93
Copy link
Contributor

Hello @msorens
Thank you for your report and we are glad that you handled it all. If you experience any additional issues we are at your disposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants