Skip to content

Investigate trajectory cost computation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acxz opened this issue Nov 13, 2019 · 3 comments
Open

Investigate trajectory cost computation #1

acxz opened this issue Nov 13, 2019 · 3 comments

Comments

@acxz
Copy link
Owner

acxz commented Nov 13, 2019

https://github.com/acxz/mppi/blob/master/mppi.m#L128

Seems to be missing a u - v term see Info-Theoretic Model Predictive Control Theory and Appl to Auto Driv https://arxiv.org/pdf/1707.02342.pdf

Edit: but in linked paper it is just v, hmmm

@acxz
Copy link
Owner Author

acxz commented Nov 20, 2019

Resolved arxiv paper was outdated, the term should be ut - vt or (eps).

See below for more proof.
https://github.com/AutoRally/autorally/blob/kinetic-devel/autorally_control/include/autorally_control/path_integral/costs.cu#L310

Keep this issue open until fixed.

@acxz
Copy link
Owner Author

acxz commented Nov 26, 2019

Okay so the computation is fixed, but the traj_cost we plot needs to be investigated. Rn we take a weighted average, but best way is to replay our dynamics with the predicted x traj.
Also the trajectory computation can be done in batches as well, doesnt need to be done in the dynamics forward propagation.

  • Batch calculate traj cost
  • Investigate the sign of the error term
  • Calculate real traj cost via replay

@acxz
Copy link
Owner Author

acxz commented Dec 12, 2019

Just adding a note to revisit/verify running cost calculation. It should not include the last state.

Edit: addressed in #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant