Merge pull request #11191 from relic-se/synthio-note-panning-fix

Fix implementation of `synthio.Note.panning`

Author: tannewt

shared-module/synthio/Note.c

@@ -196,13 +196,11 @@ static uint32_t pitch_bend(uint32_t frequency_scaled, int32_t bend_value) {
 
 uint32_t synthio_note_step(synthio_note_obj_t *self, int32_t sample_rate, int16_t dur, int16_t loudness[2]) {
     int panning = synthio_block_slot_get_scaled(&self->panning, -ALMOST_ONE, ALMOST_ONE);
-    int left_panning_scaled, right_panning_scaled;
+    int left_panning_scaled = 32768, right_panning_scaled = 32768;
     if (panning >= 0) {
-        left_panning_scaled = 32768;
-        right_panning_scaled = 32767 - panning;
+        left_panning_scaled = 32767 - panning;
     } else {
-        right_panning_scaled = 32768;
-        left_panning_scaled = 32767 + panning;
+        right_panning_scaled = 32767 + panning;
     }
 
     int amplitude = synthio_block_slot_get_scaled(&self->amplitude, -ALMOST_ONE, ALMOST_ONE);

tests/circuitpython/synth_note_panning.py

@@ -0,0 +1,10 @@
+from synthnotehelper import *
+
+
+@synth_test(channel_count=2)
+def gen(synth):
+    l = LFO(sine, offset=0.0, scale=1.0, rate=2)
+    yield [l]
+    n = Note(8, panning=l)
+    synth.press(n)
+    yield 2