Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio: Fix some issues stemming from the recent re-org #10066

Open
jepler opened this issue Feb 14, 2025 · 1 comment
Open

audio: Fix some issues stemming from the recent re-org #10066

jepler opened this issue Feb 14, 2025 · 1 comment
Milestone

Comments

@jepler
Copy link
Member

jepler commented Feb 14, 2025

  • consistently use audiosample_mark_deinit
  • remove unused functions and their prototypes, such as common_hal_audioio_rawsample_get_sample_rate(audioio_rawsample_obj_t *self);

These notes stem from my review of #10052

@jepler jepler added this to the 9.2.x milestone Feb 14, 2025
@jepler
Copy link
Member Author

jepler commented Feb 14, 2025

The missing use of mark_deinit is probably going to be causing some bugs, like the ability to use a sample after it was deinitialized, in some contexts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants