Merged
Conversation
FoamyGuy
approved these changes
Mar 26, 2026
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
This change looks good to me.
Holding off on merging until the Adabot parts are ready.
Member
Author
|
@FoamyGuy is this all set? I can't remember if this is dependent on anything else still - let me know if I can help! |
Contributor
|
It's good to merge now. The ruff adabot patch is still pending, but I am planning to run it this week after a dry run to figure out how many repos will need other changes based on the changed ruff rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE APPROVE WITH adafruit/adabot#410
Related to adafruit/adabot#407
Also, I realize I accidentally created the branch on the Adafruit upstream - I or approver can delete after merging.