Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom ConnectionFlow #306

Open
AlmogBaku opened this issue Jul 4, 2016 · 3 comments · May be fixed by #319
Open

Custom ConnectionFlow #306

AlmogBaku opened this issue Jul 4, 2016 · 3 comments · May be fixed by #319

Comments

@AlmogBaku
Copy link

Hi,
Is there any option to create a custom ConnectionFlow with LittleProxy?

@AlmogBaku
Copy link
Author

AlmogBaku commented Jul 4, 2016

In my scenario I need to do some work on the new TCP connection before using the socket of the chained proxy(state authentication).. In order to do that I had to expose few classes as public, and to add a new method to the ChainedProxy interface: ConnectionFlowStep customConnectionFlow(ProxyConnection connection);

Will you be interested in a PR?

@ganskef
Copy link
Collaborator

ganskef commented Jul 7, 2016

Hello Almog,

thank you very much! Yes, PRs are always welcome. It's interesting to
see new ideas and requirements.

But I think, this could lead to a breaking change. I know, Jason @jekh
is wondering about refactoring the connection flow. I'm evaluating some
ideas here:

 https://github.com/ganskef/shortcircuit-proxy

Regards Frank

Am 04.07.2016 um 17:51 schrieb Almog Baku:

In my scenario I need to do some work on the new TCP connection before
using the socket of the chained proxy(state authentication).. In order
to do that I had to expose few classes as public, and to add a new
method to the |ChainedProxy| interface: |ConnectionFlowStep
customConnectionFlow(ProxyConnection connection);|

Will you be interested with PR?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#306 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AKIGhgQfGvBdGFN7VzhQmznQvhMFm-QPks5qSSwagaJpZM4JEbyV.

@jekh
Copy link
Collaborator

jekh commented Jul 19, 2016

I'd love to see some ideas around the ConnectionFlow refactoring. I've been pondering this for months, but I don't have any fully-baked ideas yet. I won't be able to start devoting significant time to it until this fall, so anybody who has some thoughts, please do share!

@AlmogBaku AlmogBaku linked a pull request Oct 10, 2016 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants