Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

password_confirmation is persisted #1

Open
jamesyu opened this issue Apr 16, 2012 · 3 comments
Open

password_confirmation is persisted #1

jamesyu opened this issue Apr 16, 2012 · 3 comments

Comments

@jamesyu
Copy link

jamesyu commented Apr 16, 2012

You should probably filter out password_confirmation in the Users#create params. Right now, it creates Users and exposes the password in the password_confirmation field on Users.

@adelevie
Copy link
Owner

Agreed. Should the fix be specific to this rails app or should the logic be
in parse_resource? It's tough balancing flexibility against having things
just work.

On Monday, April 16, 2012, James Yu wrote:

You should probably filter out password_confirmation in the Users#create
params. Right now, it creates Users and exposes the password in the
password_confirmation field on Users.


Reply to this email directly or view it on GitHub:
#1

@jamesyu
Copy link
Author

jamesyu commented Apr 16, 2012

Maybe the best way is to make it so that Parse Resource only respects fields which you explicitly define in the model. That way it's kinda like attr_accessible -- hackers won't be able to inject fields willy-nilly based on form params.

@adelevie
Copy link
Owner

Agreed. Safe by default is the way to go.

On Monday, April 16, 2012, James Yu wrote:

Maybe the best way is to make it so that Parse Resource only respects
fields which you explicitly define in the model. That way it's kinda like
attr_accessible -- hackers won't be able to inject fields willy-nilly based
on form params.


Reply to this email directly or view it on GitHub:

#1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants