Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] 2 hours are added to time in Preview of Spreadsheet #406

Open
Adobe-G11N-I18N-L10N-Team opened this issue Dec 20, 2024 · 3 comments

Comments

@Adobe-G11N-I18N-L10N-Team

Expected Behaviour

Time in Preview / Publish of spreadsheet is the same as in the spreadsheet

Actual Behaviour

2 hours are added to time in Preview of Spreadsheet

Reproduce Scenario (including but not limited to)

Steps to Reproduce

  1. Install extension
  2. Add project to extension
  3. In project folder create spreadsheet file and edit it
  4. Add "Date" column
  5. Add dates with time in Date column (dd/mm/yyyy format for Google Drive, mm/dd/yyyy format for Sharepoint)
  6. Click on Preview button on action bar

Platform and Version

Chrome 131.0.6778.205
Sidekick 7.1.4

Issue is not reproducible on old Sidekick extension v6.50.1.
Issue is regress from #384

7 1 4 google enu
7 1 4 sharepoint enu
6 50 1 sharepoint

@rofe
Copy link
Contributor

rofe commented Dec 22, 2024

Is the local time on your test system GMT +2?

@Adobe-G11N-I18N-L10N-Team
Copy link
Author

@rofe Yes

@rofe
Copy link
Contributor

rofe commented Jan 20, 2025

Got it. So the JSON view assumes that if the author adds a local date/time to the sheet, that same date/time is always UTC in the resulting JSON payload, which is probably wrong. I think it should be viewed in context of the sheet's (drive's?) timezone. But how would we know that?

@dylandepass @tripodsan @davidnuescheler wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants