Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close button overhang #477

Merged
merged 1 commit into from
Feb 21, 2025
Merged

fix: close button overhang #477

merged 1 commit into from
Feb 21, 2025

Conversation

rofe
Copy link
Contributor

@rofe rofe commented Feb 18, 2025

Fix #472

Quick fix: add 5px to --sidekick-max-width

@rofe rofe requested a review from dylandepass February 18, 2025 13:43
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release@046146f). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             release      #477   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?        54           
  Lines              ?      2194           
  Branches           ?         0           
===========================================
  Hits               ?      2194           
  Misses             ?         0           
  Partials           ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rofe rofe changed the base branch from main to release February 21, 2025 20:20
@rofe rofe merged commit c9846af into release Feb 21, 2025
6 checks passed
@rofe rofe deleted the issue-472 branch February 21, 2025 20:21
rofe pushed a commit that referenced this pull request Feb 25, 2025
# [7.4.0](v7.3.0...v7.4.0) (2025-02-25)

### Bug Fixes

* close button overhang ([#477](#477)) ([c9846af](c9846af))
* **css:** body text-align bleed ([#466](#466)) ([4872eae](4872eae))
* **deps:** update external fixes ([#473](#473)) ([75cc0a3](75cc0a3))

### Features

* allow tools.aem.live and labs.aem.live to list configured sites ([#468](#468)) ([5729c25](5729c25))
* **json:** improved empty message ([#467](#467)) ([acb4774](acb4774))
* popover plugin support ([#475](#475)) ([c90a111](c90a111))
@trieloff
Copy link

🎉 This PR is included in version 7.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Position of close button can be incorrect when sidekick has multiple plugins
3 participants