feat: popover plugin support #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandepass
commented
Feb 18, 2025
| @@ -53,6 +53,7 @@ | |||
| "@spectrum-web-components/menu": "0.43.0", | |||
| "@spectrum-web-components/overlay": "0.43.0", | |||
| "@spectrum-web-components/picker": "0.43.0", | |||
| "@spectrum-web-components/popover": "0.43.0", | |||
There was a problem hiding this comment.
Already a transient dependancy, added to make eslint happy.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release #475 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 54
Lines ? 2209
Branches ? 0
===========================================
Hits ? 2209
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
rofe
reviewed
Feb 19, 2025
rofe
requested changes
Feb 21, 2025
There was a problem hiding this comment.
looks and works great!
2 comments:
- you already pass the current theme as a query parameter. but the value isn't updated dynamically when the user switches themes and reopens the popover.
- accessibility (keyboard access) seems to be a problem... maybe we can somehow set the focus inside the iframe or at least the popover, so the user can step into it? (the same problem exists with palette plugins, of course)
rofe
approved these changes
Feb 22, 2025
Co-authored-by: Raphael Wegmueller <[email protected]>
rofe
pushed a commit
that referenced
this pull request
Feb 25, 2025
# [7.4.0](v7.3.0...v7.4.0) (2025-02-25) ### Bug Fixes * close button overhang ([#477](#477)) ([c9846af](c9846af)) * **css:** body text-align bleed ([#466](#466)) ([4872eae](4872eae)) * **deps:** update external fixes ([#473](#473)) ([75cc0a3](75cc0a3)) ### Features * allow tools.aem.live and labs.aem.live to list configured sites ([#468](#468)) ([5729c25](5729c25)) * **json:** improved empty message ([#467](#467)) ([acb4774](acb4774)) * popover plugin support ([#475](#475)) ([c90a111](c90a111))
|
🎉 This PR is included in version 7.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #474