Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

How to Hack on Brackets

Jump to bottom
Peter Flynn edited this page Jan 7, 2014 · 92 revisions

This page is mainly about modifying core Brackets code. If you're adding a new feature, consider [writing an extension](How to write extensions) instead.

If you're interested in submitting a pull request, review the guidelines for contributing code. Most importantly:

  1. Discuss any major changes or questions beforehand in the brackets-dev newsgroup.
  2. Follow the Pull Request Checklist to ensure a good-quality pull request.
  3. Sign the Brackets Contributor License Agreement (CLA) - we can't merge your code otherwise. You only need to do this once.

Overview

Requirements

NOTE: All commands should be run in a Terminal window (on the Mac) or Git Bash shell (on Windows).

Setting up your dev environment

For hacking on the core Brackets HTML/CSS/JavaScript files:

  1. Fork the brackets repo
  2. Clone your fork of the repo: git clone https://github.com/<username>/brackets.git
  3. Update submodules: cd brackets and git submodule update --init
  4. Add an "upstream" remote: git remote add upstream https://github.com/adobe/brackets.git
  5. Run setup_for_hacking script:
Mac
---
tools/setup_for_hacking.sh "/Applications/Brackets.app"

Windows
-------
IMPORTANT! This command MUST be run in a Command Prompt started with "Run as Administrator"
tools\setup_for_hacking.bat "C:\Program Files (x86)\Brackets"

Linux
-----
sudo tools/setup_for_hacking.sh "/opt/brackets"

Optional: For hacking on the native code, see "Hacking on brackets-shell" below.

For more in-depth instructions see "Getting a Copy of the Code" below.

Hacking

  1. Make sure your local copy of source is up to date: git fetch upstream && git merge upstream/master
  2. Make sure submodules are up to date: git submodule sync and git submodule update --init
  3. Create a feature/bugfix branch: git checkout -b <branchname>
  4. Hack!
  5. Commit your changes: git commit -am"Your commit message here"
  6. Run unit tests

Submit pull request

  1. Push changes to your fork of the repo: git push origin <branchname>
  2. Make sure you've reviewed the Pull Request Checklist and signed the Contributor Licence Agreement (CLA).
  3. Submit pull request from GitHub. If this is a bugfix, include a reference with # followed by issue number (e.g. #1234) in the description (not title) of the issue. Note: do not use the phrase "fixes #1234" (or any form of word "fix"?) because it will cause the bug to auto-close when pull request is merged. This tags the pull request in the bug comments.

Getting Started

How Brackets is Organized

Brackets is primarily built in HTML/JS/CSS, but it currently runs as a desktop app inside a thin native app shell called brackets-shell, based on CEF, that lets it access local files. (It doesn't run in the browser yet, but we're hoping to work on an in-browser version soon.)

The HTML/JS/CSS files are installed along with brackets-shell, but you can set up a separate development copy of these files and then load them in brackets-shell instead of the default installed copy. See Running Your Copy of the Code for more details.

For details on working with Brackets's architecture and APIs, see Brackets Development How-Tos.

What should I hack on?

Whatever you want, of course! Check out the CONTRIBUTING guide for some ideas.

If you're planning to do something other than a small bugfix, please start a discussion on the brackets-dev Google group or the #brackets IRC channel on freenode to get feedback. There might already be some prior thinking on what you're working on, or some reason that it hasn't already been done. We don't want you to do tons of work and then have to rewrite half of it.

What's the process?

First, sign the Brackets Contributor License Agreement (CLA). This is for your protection as well as that of the Brackets project.

Then, just submit changes as pull requests from your own fork of brackets or brackets-shell. The core dev team works in 2.5-week sprints (weird length, but it works for us). We'll try to review small pull requests quickly in the current sprint. Larger submissions may take longer - but discussing them in advance will smooth the process!

Before you submit your pull request, please make sure it's merged with master and fully tested as described in the Pull Request Checklist.

Read more on how pull requests are reviewed...

Getting a Copy of the Code

Note: Don't use the GitHub "ZIP" to get a copy of the source. The auto-generated ZIP file will be missing important dependencies.

New to git? If all this git stuff seems scary, check out GitHub's git tutorial or the Pro Git book.

The first step is to fork the repo on GitHub so you can start making changes in your local repository. For the HTML/JS/CSS code that comprises the bulk of Brackets, you only need to fork the brackets repo. (See "Hacking on brackets-shell" below if you want to work on the native code as well). To fork a repo, simply click the "Fork" button at the top of the page.

Next pull the repositories down to your local machine.

git clone https://github.com/<your username>/brackets.git
cd brackets
git submodule update --init

Don't skip the last line! Brackets uses submodules for third-party dependencies (like CodeMirror), so it won't work until you run this command to set them up.

You may also need to run git submodule update when you switch branches or pull from upstream, since submodule changes aren't update automatically. If you see third-party code showing up as modified in git status (something like M src/thirdparty/CodeMirror2), then you need to run this command.

Running Your Copy of the Code

If you're only hacking on HTML/JS/CSS files, you can have the installed Brackets shell run your local copy of the HTML/JS/CSS code (instead of the default installed copy) by running the tools/setup_for_hacking script. Here's how:

  1. Download and install the latest Brackets sprint build.
  2. Follow "Getting a Copy of the Code" above to fork & clone the brackets repo.
  3. On a Mac:
  4. Open a Terminal window
  5. cd to the root of your brackets repo
  6. run tools/setup_for_hacking.sh, passing the full pathname to your installed Brackets.app. For example:
tools/setup_for_hacking.sh "/Applications/Brackets.app"
  1. On Windows:
  2. Open a Command Prompt using "Run as Administrator"
  3. cd to the root of your brackets repo
  4. run tools\setup_for_hacking.bat, passing the full path of the directory where Brackets.exe is installed. For example:
tools\setup_for_hacking.bat "C:\Program Files (x86)\Brackets"
  1. Launch the installed copy of Brackets, select Help > About, and verify that the version number says "sprint xx development build" instead of "sprint xx experimental build". This indicates that you're running Brackets from your git repo instead of the installed build.

You can revert back to running the installed version of the Brackets source at any time by running tools/restore_installed_build.sh (Mac) or tools\restore_installed_build.bat (Windows) from your Brackets repo.

Getting Updates from the Main Repository

It's important to keep up to date with the main Brackets repository to make sure your pull requests match the latest Brackets builds. First you'll first need to link your local clone of Brackets to track the main Brackets repository on GitHub. Run this command from the brackets directory:

cd brackets
git remote add upstream https://github.com/adobe/brackets.git

Your repo will now have two "remotes": origin refers to your fork on GitHub, while upstream refers to the original, official Brackets repo.

If you want to avoid getting branches other than master, you can add the --track master argument after add. However, that will mean that if you need to pull a different branch, you'll need to explicitly fetch it.

If you also forked the brackets-shell repository, repeat this command for brackets-shell.

Getting the latest changes

Getting the latest changes on the Brackets master branch is a two-step process. First:

git fetch upstream

This brings down any new commits into your repo, but doesn't actually update any of your branches. Next, update your current local branch:

git merge upstream/master

This merges any changes from the main Brackets repository into whichever branch you currently have checked out locally. (To update multiple local branches, you'll need to git checkout each one in turn and repeat the merge command).

You may also need to run git submodule update at this point - if the output of git fetch said "Fetching submodule" or if git status shows an unexpected diff in a third-party library.

Rarely, an entire new submodule is added to Brackets. You'll need to run git submodule update --init when that happens.

What changes did I get?

You can see a diff before merging with git difftool ...upstream/master.

For a higher-level overview (with API important changes called out), check the Release notes after each sprint.

Contributing Code

Useful Tools for Development

If you use Brackets to edit Brackets, you can quickly reload the app itself by choosing Debug > Reload Brackets from the in-app menu. [More on debugging Brackets...](Debugging Brackets)

You can use Debug > Run Tests to run our unit test suite. Use Debug > Show Perf Data to show some rudimentary performance info (see the PerfUtils API for adding more).

Saving Your Code Changes

If you've found an issue you want to fix or a feature you want to implement, eventually you'll want to submit a pull request back to Brackets upstream. Here's how to organize your changes so they're ready to turn into a pull request.

First, create a new branch off of master for the change you want to work on. This allows your master branch to stay in sync with the main Brackets repository - and if your change doesn't work or breaks something, you can always start fresh from your local master again.

git checkout master
git branch mynewfeature
git checkout mynewfeature

That creates a new branch called mynewfeature and sets it as your working branch. Any changes you make now will be linked to that branch. While you work on it, you should still keep your branch in sync with Brackets master following the "Getting Updates from the Main Repository" steps above.

Now go ahead and modify some code, make your fix, and be sure that it works in your copy of Brackets. As always, please follow the guidelines for contributing code to ensure your code matches what's expected for Brackets contributions.

Next it's time to commit your changes to your local git repo. Use git add <filename> to stage any modified files for committing, then use git commit -m "COMMIT MESSAGE" to commit those files. (Or just use use git commit -am "COMMIT MESSAGE" to commit all modified files). Be sure to write a thorough commit message that describes the changes you're making and why.

The last step before submitting a pull request is to push those changes to your GitHub account - so far the changes are only stored in your local copy of the Brackets repository. Remember that your GitHub fork of the Brackets repo is called "origin"... so to push your changes use:

git push origin mynewfeature

That command creates a matching branch on your GitHub-hosted repo and copies your branch's commits into it. Now your commits are stored on the GitHub server and not just locally.

This is a good time to review the Pull Request Checklist - make sure your code passes JSLint, doesn't break any unit tests, etc.

Submitting a Pull Request

Now you're ready to submit a pull request. Go to the GitHub page for your fork of Brackets and choose your branch from the dropdown near the upper left (it says master by default). Now you're looking at the code for that branch.

Click the Pull Request button in the top right and you'll be brought to a page that describes the pull request. Make sure you're submitting to the adobe/brackets repository, from the branch you've been working on.

Review the "Commits" and "Files Changed" tabs to make sure you're submitting only the changes you intend. Write a detailed description of what your pull request does (including any associated bug numbers, e.g. "issue #1234", to ensure the pull request is linked to the bug). Then click "Send pull request."

Congratulations on submitting your pull request - you've helping make Brackets even better! Read about the pull request review process for what happens next.

Updating an Existing Pull Request

During code review, you will probably be asked to make some changes to your code. First, make sure you're working on the correct branch:

git checkout mynewfeature

Then make the necessary code changes. When done, repeat the git commit and git push steps from above.

Ta daa! As soon as you've pushed those changes to "origin" (your fork on GitHub), your pull request is automatically updated with the new code. Finally, add a comment to the pull request describing the new changes - this ensures the code reviewer is notified of your update.

Hacking on brackets-shell

For most of your changes to Brackets, you should only need to edit the HTML/JS/CSS code in the brackets repo. You won't need the source for brackets-shell because you can use a pre-built binary from a Brackets installer to run your modified HTML/JS/CSS code (see instructions above).

However, you may want to set up a dev environment for brackets-shell if:

  • You want to hack on the native code.
  • You want to pull the latest from the brackets repo master and it requires a new brackets-shell build that hasn't been released as a binary yet. (This is uncommon, but it can happen).
  1. Similar to the steps above, fork the bracket-shell repo and git clone it.
  2. Follow the build instructions on the brackets-shell wiki.
Clone this wiki locally