Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLA bot is failing on new merge queue feature #157

Open
shazron opened this issue Mar 9, 2023 · 0 comments
Open

CLA bot is failing on new merge queue feature #157

shazron opened this issue Mar 9, 2023 · 0 comments

Comments

@shazron
Copy link
Member

shazron commented Mar 9, 2023

Github merge queue: Adobe CLA check is stuck. Any ideas to get it unstuck? It probably can't recognize this new workflow (which at least for us will help with all the Dependabot PRs) and errors out.

  1. https://github.blog/changelog/2023-02-08-pull-request-merge-queue-public-beta/
  2. https://github.com/adobe/aio-cli/queue/master (click on any of the paper icons next to a queue entry) - If you don't see anything in the queue later today, it's because it was removed for no response from a check

Trying to read the cla-bot code - it appears that the bot probably threw an exception that was not handled, my guess is it's an undefined var at https://github.com/adobe/cla-bot/blob/602108f954f90edae74e8caa38cd12744b60c55a/checker/checker.js#LL36C47-L36C47

Does anyone at the OSO have access to the runtime logs, or are they forwarded to Splunk? https://github.com/adobe/cla-bot/blob/master/checker/checker.js

I believe the event is merge_group so will need to test for that instead of pull_request: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue

merge_group params are different from pull_request: https://docs.github.com/en/webhooks-and-events/webhooks/webhook-events-and-payloads#merge_group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant