Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should an error in the cla bot execution render a check on PRs? #18

Open
stevengill opened this issue Jan 10, 2019 · 1 comment
Open

should an error in the cla bot execution render a check on PRs? #18

stevengill opened this issue Jan 10, 2019 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@stevengill
Copy link
Contributor

Right now, if a promise fails in checker.js, it returns an error. Instead, maybe we should still run a failed check on github?
@filmaj
Copy link
Contributor

filmaj commented Jan 10, 2019

Or maybe we set the check to neutral?

@filmaj filmaj added enhancement New feature or request question Further information is requested labels Jan 11, 2019
@filmaj filmaj changed the title unexpected results in checker.js return broken promise should an error in the cla bot execution render a check on PRs? Aug 19, 2019
@filmaj filmaj added the help wanted Extra attention is needed label Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@filmaj @stevengill