Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/bug: Enable the bot as a required check #43

Open
shazron opened this issue Jan 23, 2019 · 4 comments
Open

Documentation/bug: Enable the bot as a required check #43

shazron opened this issue Jan 23, 2019 · 4 comments
Labels
bug Something isn't working docs Related to project documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@shazron
Copy link
Member

shazron commented Jan 23, 2019

Even though the bot is installed, it won't be available as a status check to be "required" until the first pull request. Thus any subsequent pull requests might be free to merge (thus I call it a 'bug' if a CLA is a legal requirement)

Repo owners need to "prime" their repos first, so the Adobe CLA bot is available in Settings -> Branches -> Branch protection rules -> (master) -> Edit. Only after it is available, then can it be checked (thus it will be Required). This needs to be a documentation thing for repos that have it enabled, perhaps file an issue automatically or PR (not sure how that would work).

See screenshot below:

screen shot 2019-01-23 at 11 56 01 am

@shazron
Copy link
Member Author

shazron commented Jan 23, 2019

Not sure if this is useful: https://github.com/probot/settings

@stevengill
Copy link
Contributor

Thanks @shazron! This is very useful and definitely worth documenting.

@filmaj filmaj added bug Something isn't working docs Related to project documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 15, 2019
@prashcr
Copy link
Contributor

prashcr commented Oct 12, 2019

Here's my understanding of this issue, let me know if it's correct:

Repro
Install bot in an organization
Attempt to enable the bot as a required check for PRs

Actual
A PR needs to be created before the bot shows up as a check in repo settings
There is no documentation of this behavior

Expected
Document this behavior
Or ideally, automatically file a PR against all org repos that "primes" the repos and reminds owners to enable the bot as a required check

@shazron
Copy link
Member Author

shazron commented Oct 15, 2019

@prashcr yes that is correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Related to project documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants