Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reporting of checks in setgithubcheck #70

Open
filmaj opened this issue Oct 1, 2019 · 3 comments
Open

Improve reporting of checks in setgithubcheck #70

filmaj opened this issue Oct 1, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@filmaj
Copy link
Contributor

filmaj commented Oct 1, 2019

It would be nice if the setgithubcheck action reported more than just the PR author's status. Currently it reports one of three statuses:

  • whether the author is an Adobe employee (and how it determined employeeship)
  • whether a signed CLA was found (and what github user it was found for)

It would be nice (for monitoring and debugging purposes) to also report:

  • the repo/pr/url of the report
@filmaj filmaj added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 1, 2019
@souravsingh
Copy link

@filmaj I am interested in working on the issue.

@filmaj
Copy link
Contributor Author

filmaj commented Oct 2, 2019

That's awesome @souravsingh ! Thanks for your offer to help.

I think what we want to expand here is the summary parameter of the setgithubcheck action. Currently, it is invoked in two other actions in several area:

Hopefully that's clear, let me know if you'd like to take this on and I can assign the issue to you.

@filmaj
Copy link
Contributor Author

filmaj commented Oct 9, 2019

BTW I recently added better reporting for the signwebhook action (in #82)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants