Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into github action to push PRs from forks to origin on review approval #80

Open
filmaj opened this issue Oct 8, 2019 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed infrastructure automation for this project question Further information is requested

Comments

@filmaj
Copy link
Contributor

filmaj commented Oct 8, 2019

Since the full integration test suite in this repo relies on sensitive keys, we cannot trust pull requests from branches not on this repo's origin. Someone could do something malicious with those keys. As such, for legit, non-malicious and well intentioned folks sending PRs to this repo, after reviewing the code, I have to push their code to a branch on this origin in order to trigger the full integration test suite.

Would be cool to automate this song-n-dance.

Could base it on something from here? https://github.com/sdras/awesome-actions#pull-requests

@filmaj filmaj added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Oct 8, 2019
@filmaj filmaj added the infrastructure automation for this project label Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed infrastructure automation for this project question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant