Merge pull request #145 from adobe/remove-error-hover

chore: remove error hover and disable save when JSON is invalid

Author: fkakatie

tools/admin-edit/admin-edit.css

@@ -31,6 +31,10 @@
   height: 66vmin;
 }
 
+.admin-edit textarea#body.error {
+  border-color: var(--red-900);
+}
+
 /**
  * "Creating an Editable Textarea That Supports Syntax Highlighted Code" by Oliver Geer
  * Published on CSS-Tricks: https://css-tricks.com/creating-an-editable-textarea-that-supports-syntax-highlighted-code/

tools/admin-edit/admin-edit.js

@@ -67,7 +67,11 @@ function validateJSON(code) {
     const json = JSON.parse(code);
     previewWrapper.removeAttribute('data-line');
     previewWrapper.removeAttribute('data-error');
+    document.getElementById('save').disabled = false;
+    document.getElementById('body').classList.remove('error');
   } catch (error) {
+    document.getElementById('save').disabled = true;
+    document.getElementById('body').classList.add('error');
     // json is INVALID
     const { message } = error;
     // extract line of error (if it exists)

tools/admin-edit/line-highlight.js

@@ -59,8 +59,8 @@
       // add data attributes
       const { error } = element.dataset;
       if (error) {
-        highlight.dataset.error = error;
-        highlight.classList.add('error-hover');
+        // highlight.dataset.error = error;
+        // highlight.classList.add('error-hover');
       }
       if (!hasClass(element, 'line-numbers')) {
         highlight.dataset.start = startLine;

tools/page-status/orphaned-pages-popover.js

@@ -103,6 +103,7 @@ function displayJobDetails() {
 }
 
 async function unpublishOrphanedPages(paths) {
+  // eslint-disable-next-line no-console
   console.log('Unpublishing', paths);
   const options = {
     body: JSON.stringify({