Confusion about TS strict-mode support. noImplicityAny: true fails build

[VapidLinus]

In the past I could not build my project with full TS strict-mode, especially noImplicityAny: true as this caued my build to fail:

./node_modules/@react-aria/button/src/useButton.ts:112:17
Type error: Parameter 'e' implicitly has an 'any' type.

  110 |       'aria-controls': props['aria-controls'],
  111 |       'aria-pressed': props['aria-pressed'],
> 112 |       onClick: (e) => {
      |                 ^
  113 |         if (deprecatedOnClick) {
  114 |           deprecatedOnClick(e);
  115 |           console.warn('onClick is deprecated, please use onPress');

So in my tsconfig I've always had this in my config:

// TODO: We should strive towards this being true.
//       react-aria has issues building with it being true for now.
"noImplicitAny": false,

Now with the November Release claiming "React Spectrum and React Aria are now Typescript Strict compliant!" , I went ahead and updated all my react-aria dependencies, enabled noImplicitAny again and compiled!

To then again just be greeted with the same error as in the start of this post. I checked the source code here on GitHub and indeed, that section of the code has not changed and does use an implicit any:

react-spectrum/packages/@react-aria/button/src/useButton.ts

Line 111 in 3e1c518

onClick: (e) => {

Disabling noImplicitAny again and now my build compiles. I really though this release would let me enable no impliciy any again, but it appears not.

Both my build system and IDE reports this as an error when I turn on no implicit any:
./node_modules/@react-aria/button/src/useButton.ts:112:17

Back in May I made a discussion about this same thing, where @snowystinger suggested this could be fixed by either #3183 or #1890, and now both of those issues are closed.

Am I missunderstanding something here? Can someone point me in the right direction? Any guideance would be greatly appreciated.

[devongovett]

Why are you type checking React Aria's source code (src directory)? Shouldn't typescript be picking up the compiled d.ts files?

[VapidLinus]

- Shouldn't typescript be picking up the compiled d.ts files?

Maybe? I do not appear to have a useButton.d.ts file anywhere in node_modules anywhere, only the useButton.ts. Is there a types package I am missing? I followed the instructions on the documentation to install react-aria hooks, but I do not see any mention of a types package or typescript in your docs or your published npm packages.

Scratch that, I am finding the types.d.ts if I "go to definition" when using a useButton:
node_modules/@react-aria/button/dist/types.d.ts

I do not understand why it complains then when I compile :s

My full list of react-aria dependencies are as follows:

    "dependencies": {
        "react-aria": "^3.37.0",
        "react-stately": "^3.35.0",
        "@react-stately/collections": "^3.12.1",
    },
    "devDependencies": {
        N/A
    }

Am I missing any dev dependency of yours that is supposed to be providing types/d.ts files? If not a package, what step is supposed to generate the type files? I see most types in the normal .ts files and they all work fine except for this one case.

- Why are you type checking React Aria's source code (src directory)?

I am not exactly sure why this happens but I've done research before and it seems like this is intended/unsolved?
I have skipLibCheck: true in my tsconfig and exclude node_modules:

{
  "compilerOptions": 
    ...,
    "skipLibCheck": true,
    "strict": true,
    "noImplicitAny": true
  },
  ...,
  "exclude": [
    "node_modules",
    "./node_modules",
    "./node_modules/*"
  ]
}

According to this answer on SO, this will still have TS type the dependencies and that is apparently working as intended:

The compiler needs to go through the modules typing to give the proper type checking for you.
One of the issues is that it does not skip check in node_modules if the package includes .ts files.
The issue is marked as working as intended.

If you are aware of any way to configure this further, please advice.

[devongovett]

That package definitely has a "types" field in its package.json pointing to a .d.ts file: https://www.unpkg.com/browse/@react-aria/[email protected]/package.json

[VapidLinus]

Thanks to your guidance I managed to identify the issue. It is kind of embarrassing in hindsight, but I didn't even know to look for this. I am still learning about the web ecosystem and didn't know to look for this. After scouring through our source code, I found out we have this import:

import type { AriaToggleButtonOptions } from "@react-aria/button/src/useToggleButton"

This import path was highly suspect so I changed it to this:

import type { AriaToggleButtonProps } from "@react-types/button"

So this was obviously a mistake on my part. I missed the suspect import path. My guess now is that importing something from your src directory caused us to compile your entire source-code, which then failed on the mentioned onPress line. None of the errors pointed in this direction at all, so without knowing to look for it, I didn't identify it. This should have been identified earlier on my part. I have certainly learned a lesson.

Thank you for your time!

[devongovett]

Good catch! Glad you found the issue.