-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON error when run command #5
Comments
Yep. Same here. |
Hey both of you! 👋🏻 Is it possible to share the repository where you try to run the command? |
Hey! I'm trying to run on thisdatedoesnotexist-server. It's still using AdonisJS v5. I'm trying to update it to v6. |
sorry I missed that issue. i will take a look |
@samuel-s-marques can you give more information? I just tried to run upgrade-kit on your repo and it seems to works fine. Can you give your node version and also the command/patch you ran? I'm using Node 21.6 |
I had the same problem and found this code in upgrade-kit/src/runner.ts loader.update('Loading config files')
this.#patchers = this.#options.patchers.map((factory) => factory(this))
this.rcFile = new RcFile(join(this.#options.projectPath, '.adonisrc.json'))
this.tsConfigFile = new Tsconfig(join(this.#options.projectPath, 'tsconfig.json'))
this.pkgJsonFile = new PkgJson(join(this.#options.projectPath, 'package.json')) For me the problem was that in my
There are multiple .json configs so it could be that you need to check the other config files as well (.adonisrc.json, tsconfig.json, package.json). This fixed the error for me. I also had another error message but it resolved after I upgraded to node v21. |
Same problem here. @royvanderzon's solution didn't work. I had no comments in any of my json files. |
i need a repro or at least more informations. otherwise there's nothing I can do to help |
I had a similar issue and it wasn't a comment that was causing the problem, but the last element of an object in my |
Package version
@adonisjs/[email protected]
Describe the bug
I had this bug when try to update the version.
Node version used: v20.9.0
I tried installing the package with pnpm, npm and yarn. With yarn I get a node version error... and the others I get the error above when execute the command.
Reproduction repo
No response
The text was updated successfully, but these errors were encountered: