Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Removing prts related files #2576

Open
aryanpola opened this issue Feb 26, 2025 · 5 comments
Open

[ENH] Removing prts related files #2576

aryanpola opened this issue Feb 26, 2025 · 5 comments
Assignees
@aryanpola
Labels
anomaly detection Anomaly detection package benchmarking Benchmarking package enhancement New feature, improvement request or other non-bug code enhancement

Comments

@aryanpola
Copy link
Contributor

aryanpola commented Feb 26, 2025 •
edited
Loading

Related PR #2400

  1. Remove the older functions from aeon\benchmarking\metrics\anomaly_detection\_binary.py that use prts as a dependency.
  2. Update the tests. They should compare the hard-coded values with the new implementation output.
  3. Remove prts from all_extras.
@aryanpola
Copy link
Contributor Author

@aeon-actions-bot assign @aryanpola

@aryanpola aryanpola changed the title Removing prts related files [ENH] Removing prts related files Feb 26, 2025
@aryanpola aryanpola changed the title Removing prts related files [ENH] Removing prts related files Feb 26, 2025
@Sharathchenna
Copy link
Contributor

@aryanpola Can i work on this part?

@MatthewMiddlehurst MatthewMiddlehurst added enhancement New feature, improvement request or other non-bug code enhancement benchmarking Benchmarking package anomaly detection Anomaly detection package labels Mar 3, 2025
@MatthewMiddlehurst
Copy link
Member

As these are part of benchmarking, they must be deprecated first. Please read our deprecation guide if you want to do this yourself.

@aryanpola
Copy link
Contributor Author

@MatthewMiddlehurst Since the older functions will be removed in the upcoming version, would a single PR addressing the deprecation of functions from aeon\benchmarking\metrics\anomaly_detection\_binary.py be sufficient for now?

Also, would you like me to address in a new PR or the existing PR (#2400 )?

@MatthewMiddlehurst
Copy link
Member

I would do it in a new PR

@aryanpola aryanpola mentioned this issue Mar 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aryanpola aryanpola

Labels
anomaly detection Anomaly detection package benchmarking Benchmarking package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MatthewMiddlehurst @Sharathchenna @aryanpola