Merge pull request #223 from agile-ts/develop

New Release 🎉

Author: bennobuilder

.changeset/chatty-bulldogs-smash.md

@@ -0,0 +1,19 @@
+---
+'@agile-ts/api': patch
+'@agile-ts/core': patch
+'@agile-ts/event': patch
+'@agile-ts/logger': patch
+'@agile-ts/multieditor': patch
+'@agile-ts/proxytree': patch
+'@agile-ts/react': patch
+'@agile-ts/utils': patch
+'@agile-ts/vue': patch
+---
+
+#### :bug: Bug Fix
+* `core`
+    * [#220](https://github.com/agile-ts/agile/pull/220) synchronously recompute value after state change ([@leopf](https://github.com/leopf))
+
+#### Committers: 2
+- BennoDev ([@bennodev19](https://github.com/bennodev19))
+- [@leopf](https://github.com/leopf)

.circleci/config.yml

@@ -1,19 +1,15 @@
 # Following this caching concept https://circleci.com/docs/2.0/persist-data/
+# https://circleci.com/docs/language-javascript
 
 version: 2.1
 
 orbs:
-  node: circleci/[email protected]
-
-executors:
-  node-executor:
-    docker:
-      - image: circleci/node:14
+  node: circleci/[email protected]
 
 jobs:
 
   build:
-    executor: node-executor
+    executor: node/default # Docker environment in what to execute the steps
     steps:
       # Checkout Project from Github
       - checkout
@@ -31,9 +27,9 @@ jobs:
      #       # fallback to using the latest cache if no exact match is found
      #       - v1-dependencies-
 
-      - run:
-         name: ⏳ Install
-         command: yarn install
+#      - run:
+#         name: ⏳ Install
+#         command: yarn install
 
      # Not necessary because of auto caching of circleci/[email protected]
      # - save_cache:
@@ -55,7 +51,7 @@ jobs:
           paths: [ ./* ]
 
   test:
-    executor: node-executor
+    executor: node/default
     steps:
       # https://circleci.com/docs/2.0/configuration-reference/#attach_workspace
       - attach_workspace:
@@ -70,7 +66,7 @@ jobs:
           command: yarn run test --runInBand # Tests somehow only get executed with the '--runInBand' Flag
 
   test-coverage:
-    executor: node-executor
+    executor: node/default
     steps:
       # https://circleci.com/docs/2.0/configuration-reference/#attach_workspace
       - attach_workspace:

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,6 +1,6 @@
 ---
 name: 🐛 Bug report
-about: Create a report to help us improve AgileTs
+about: Create a bug report to help us improve AgileTs
 title: ''
 labels: 'Type: Bug'
 assignees: ''
@@ -11,35 +11,36 @@ assignees: ''
 
 ### 🤖 Current Behavior
 
-<!-- Explain your problem (with screenshots, videos, text) in detail -->
+<!-- Explain your problem (e.g. with screenshots, text, code snippets) in detail -->
 
 ### 🎯 Expected behavior
 
 <!-- A clear and concise description of what you expected to happen. -->
 
 ### 📄 Reproducible example
 
-<!-- Create a simple example in Codebox -->
+<!-- Create a simple example that reproduces your problem in a code sandbox 
+     (like this one: https://codesandbox.io/s/issue-219-ufcck?file=/src/main.js) -->
 
 ### 💡 Suggested solution(s)
 
-<!-- How could we solve this bug? What changes would need to made to AgileTs? -->
+<!-- How could we solve this bug? What changes would need to made to AgileTs? Any idea? -->
 
 ### ➕ Additional notes
 
-<!-- Add any other context about the problem here.  -->
+<!-- Add additional context about the problem here. (optional) -->
 
 ### 💻 Your environment
 
-<!-- PLEASE FILL THIS OUT -->
+<!-- What version/s of AgileTs are you using? -->
 
 | Software              | Version(s) |
 | ----------------------| ---------- |
-| TypeScript            |
-| npm/Yarn              |
-| NodeJs                |
-| @agile-ts/core        |
-| @agile-ts/react       |
-| @agile-ts/api         |
-| @agile-ts/multieditor |
-<!-- Any additional important Version Notes? -->
+| @agile-ts/core        | N/A
+| @agile-ts/react       | N/A
+| @agile-ts/api         | N/A
+| @agile-ts/multieditor | N/A
+| TypeScript            | N/A
+| npm/Yarn              | N/A
+| NodeJs                | N/A
+<!-- Any additional important version notes? -->

.gitignore

@@ -13,7 +13,6 @@ yarn-debug.log*
 yarn-error.log*
 .eslintcache
 package-lock.json
-yarn.lock
 
 # Editor directories and files
 .idea

CONTRIBUTING.md

@@ -233,7 +233,11 @@ Generate a GitHub auth token by going to https://github.com/settings/tokens
 
 Generate the changelog in the `root` of the project with:
 ```sh
+# Linux
 GITHUB_AUTH=<Your GitHub auth token> yarn run changelog
+
+# Windows
+set GITHUB_AUTH=<Your GitHub auth token> && yarn run changelog
 ```
 Copy the generated content and paste it as a description into the in [Step 3](#3-create-pull-request-to-master)
 created `Pull Request`. Save the changelog somewhere in between because we need it again in the next step ([Step 5](#5-bump-version)).

README.md

@@ -1,8 +1,12 @@
- > ⚠️ **No longer actively maintained**. If there is more interest and people want to use this package, I will be happy to continue working on it. cheers
- > 
- > ❓ If you've any questions feel free to open a [discussions](https://github.com/agile-ts/agile/discussions).
- 
- <img src="https://raw.githubusercontent.com/agile-ts/agile/master/static/header_background.png" alt="AgileTs">
+> ⚠️ **No longer actively maintained**. 
+> In case there will be a higher demand and more known bugs in the future, 
+> I will be happy to continue improving this project. 
+> But as for now its stable and can be used in any sort of project.
+> In case you face any problem feel free open an [issue](https://github.com/agile-ts/agile/issues).
+>
+> ❓ If you've any questions, don't hesitate to start a [discussion](https://github.com/agile-ts/agile/discussions).
+
+<img src="https://raw.githubusercontent.com/agile-ts/agile/master/static/header_background.png" alt="AgileTs">
 
 > 🎇 **Global State and Logic Library**
 
@@ -248,3 +252,6 @@ To find out more about contributing, check out the [CONTRIBUTING.md](https://git
 
 AgileTs is inspired by [MVVM Libraries](https://de.wikipedia.org/wiki/Model_View_ViewModel) 
 like [MobX](https://mobx.js.org/README.html) and [PulseJs](https://github.com/pulse-framework/pulse).
+
+### 🕐 Time spent building this project
+[![wakatime](https://wakatime.com/badge/user/aa5a8ce7-1c57-4f26-a159-ea57ec5ea7c1/project/6d1a7308-89b1-4e95-9623-64c0c6116d0a.svg)](https://wakatime.com/badge/user/aa5a8ce7-1c57-4f26-a159-ea57ec5ea7c1/project/6d1a7308-89b1-4e95-9623-64c0c6116d0a)

examples/react/develop/fields/src/App.js

@@ -52,7 +52,8 @@ export default function App() {
             id: FIELDS.size,
             name: `Field #${FIELDS.size + 1}`,
           });
-        }}>
+        }}
+      >
         Add Field
       </button>
     </div>

examples/react/develop/functional-component-ts/yarn.lock

@@ -3,36 +3,36 @@
 
 
 "@agile-ts/api@file:.yalc/@agile-ts/api":
-  version "0.0.24"
+  version "0.0.25"
   dependencies:
-    "@agile-ts/utils" "^0.0.10"
+    "@agile-ts/utils" "^0.0.11"
 
 "@agile-ts/core@file:.yalc/@agile-ts/core":
-  version "0.2.6"
+  version "0.2.7"
   dependencies:
-    "@agile-ts/utils" "^0.0.10"
+    "@agile-ts/utils" "^0.0.11"
 
 "@agile-ts/event@file:.yalc/@agile-ts/event":
-  version "0.0.13"
+  version "0.0.14"
 
 "@agile-ts/logger@file:.yalc/@agile-ts/logger":
-  version "0.0.10"
+  version "0.0.11"
   dependencies:
-    "@agile-ts/utils" "^0.0.10"
+    "@agile-ts/utils" "^0.0.11"
 
 "@agile-ts/multieditor@file:.yalc/@agile-ts/multieditor":
-  version "0.0.23"
+  version "0.0.24"
 
 "@agile-ts/proxytree@file:.yalc/@agile-ts/proxytree":
-  version "0.0.8"
+  version "0.0.9"
 
 "@agile-ts/react@file:.yalc/@agile-ts/react":
-  version "0.2.2"
+  version "0.2.3"
 
-"@agile-ts/utils@^0.0.10":
-  version "0.0.10"
-  resolved "https://registry.yarnpkg.com/@agile-ts/utils/-/utils-0.0.10.tgz#5eb2d7b7faefc00c416165ad93c79237e8448bbd"
-  integrity sha512-eVJZS60H8HaD8atTfswObihdDxjcxNlaoHk8Crmz85KOrdIMBMdrGx41p+Zf15s+dSfal1gbgM2In3bw4zjSww==
+"@agile-ts/utils@^0.0.11":
+  version "0.0.11"
+  resolved "https://registry.yarnpkg.com/@agile-ts/utils/-/utils-0.0.11.tgz#3680407e92528f0e372af28983872c20b80b395c"
+  integrity sha512-tbrlXbo3ukoODodl4Og99BG/glhk9NUO09LJ7qdQ25/coL13lNzQQix9Z5IFohEIeJ71Y4ZIGzJmmui29FxTKA==
 
 "@babel/[email protected]":
   version "7.8.3"

examples/react/develop/simple-todo-list/src/App.js

@@ -30,7 +30,8 @@ const App = () => {
             method: 'unshift', // to add todo at the beginning of the Collection
           });
           setCurrentInput('');
-        }}>
+        }}
+      >
         Add
       </button>
       {todos.map((value) => (
@@ -41,7 +42,8 @@ const App = () => {
             onClick={() => {
               // Remove Todo at specific primary Key
               TODOS.remove(value.id).everywhere();
-            }}>
+            }}
+          >
             Remove
           </button>
         </div>

package.json

@@ -17,7 +17,6 @@
   "syncDir": "dist",
   "scripts": {
     "build": "lerna run build",
-    "prepare": "lerna run prepare",
     "changelog": "lerna-changelog",
     "bootstrap": "lerna bootstrap",
     "watch:core": "cd packages/core && yarn run watch",
@@ -41,7 +40,8 @@
     "pack:react": "cd packages/react && yarn run prepare && yarn run pack",
     "pack:multieditor": "cd packages/multieditor && yarn run prepare && yarn run pack",
     "pack:api": "cd packages/api && yarn run prepare && yarn run pack",
-    "pack:event": "cd packages/event && yarn run prepare && yarn run pack"
+    "pack:event": "cd packages/event && yarn run prepare && yarn run pack",
+    "install:clean": "shx rm -rf yarn.lock && shx rm -rf node_modules && yarn install && lerna run install:clean"
   },
   "repository": {
     "type": "git",

packages/api/package.json

@@ -26,7 +26,6 @@
   },
   "scripts": {
     "build": "shx rm -rf dist && rollup --c rollup.config.js",
-    "prepare": "yarn run build",
     "dev:publish": "yalc publish",
     "dev:push": "yalc push",
     "watch:push": "tsc-watch --onSuccess \"yarn run dev:push\"",

packages/core/package.json

@@ -37,7 +37,6 @@
   },
   "scripts": {
     "build": "shx rm -rf dist && rollup --c rollup.config.js",
-    "prepare": "yarn run build",
     "dev:publish": "yalc publish",
     "dev:push": "yalc push",
     "watch:push": "tsc-watch --onSuccess \"yarn run dev:push\"",

packages/core/src/collection/collection.persistent.ts

@@ -1,7 +1,7 @@
 import { defineConfig } from '@agile-ts/utils';
 import { logCodeManager } from '../logCodeManager';
 import { Collection, CollectionKey, DefaultItem, ItemKey } from './collection';
-import { Group, GroupKey } from './group';
+import type { Group, GroupKey } from './group';
 import {
   CreatePersistentConfigInterface,
   getSharedStorageManager,
@@ -137,9 +137,8 @@ export class CollectionPersistent<
         // that it was loaded completely.
         // After a successful loading assign the now valid Item to the Collection.
         else {
-          const placeholderItem = this.collection().getItemWithReference(
-            itemKey
-          );
+          const placeholderItem =
+            this.collection().getItemWithReference(itemKey);
           placeholderItem?.persist({
             key: itemStorageKey,
             loadValue: false,
@@ -148,7 +147,8 @@ export class CollectionPersistent<
             followCollectionPersistKeyPattern: false, // Because of the dynamic 'storageItemKey', the key is already formatted above
           });
           if (placeholderItem?.persistent?.ready) {
-            const loadedPersistedValueIntoItem = await placeholderItem.persistent.loadPersistedValue();
+            const loadedPersistedValueIntoItem =
+              await placeholderItem.persistent.loadPersistedValue();
 
             // If successfully loaded Item value, assign Item to Collection
             if (loadedPersistedValueIntoItem) {

packages/core/src/collection/collection.ts

@@ -7,9 +7,9 @@ import {
   normalizeArray,
 } from '@agile-ts/utils';
 import { logCodeManager } from '../logCodeManager';
-import { Agile } from '../agile';
+import type { Agile } from '../agile';
 import { PatchOptionConfigInterface } from '../state';
-import { ComputedTracker } from '../computed';
+import { ComputedTracker } from '../computed/computed.tracker'; // Not imported directly from '../computed' due circular dependencies
 import { Item } from './item';
 import { SelectorConfigInterface, Selector, SelectorKey } from './selector';
 import {
@@ -20,7 +20,7 @@ import {
   TrackedChangeMethod,
 } from './group';
 import { GroupIngestConfigInterface } from './group/group.observer';
-import { CreatePersistentConfigInterface, StorageKey } from '../storages';
+import { CreatePersistentConfigInterface } from '../storages';
 import { CollectionPersistent } from './collection.persistent';
 
 export class Collection<DataType extends DefaultItem = DefaultItem> {
@@ -1181,9 +1181,7 @@ export class Collection<DataType extends DefaultItem = DefaultItem> {
    * @public
    * @param itemKeys - Item/s with identifier/s to be removed.
    */
-  public remove(
-    itemKeys: ItemKey | Array<ItemKey>
-  ): {
+  public remove(itemKeys: ItemKey | Array<ItemKey>): {
     fromGroups: (groups: Array<ItemKey> | ItemKey) => Collection<DataType>;
     everywhere: (config?: RemoveItemsConfigInterface) => Collection<DataType>;
   } {
@@ -1518,13 +1516,12 @@ export interface CreateCollectionConfigImpl<
   initialData?: Array<DataType>;
 }
 
-export type CreateCollectionConfig<
-  DataType extends DefaultItem = DefaultItem
-> =
-  | CreateCollectionConfigImpl<DataType>
-  | ((
-      collection: Collection<DataType>
-    ) => CreateCollectionConfigImpl<DataType>);
+export type CreateCollectionConfig<DataType extends DefaultItem = DefaultItem> =
+
+    | CreateCollectionConfigImpl<DataType>
+    | ((
+        collection: Collection<DataType>
+      ) => CreateCollectionConfigImpl<DataType>);
 
 export interface CollectionConfigInterface {
   /**
@@ -1542,8 +1539,9 @@ export interface CollectionConfigInterface {
   defaultGroupKey: ItemKey;
 }
 
-export interface CollectConfigInterface<DataType = any>
-  extends AssignDataConfigInterface {
+export interface CollectConfigInterface<
+  DataType extends DefaultItem = DefaultItem
+> extends AssignDataConfigInterface {
   /**
    * In which way the collected data should be added to the Collection.
    * - 'push' =  at the end

packages/core/src/collection/group/group.observer.ts

@@ -6,7 +6,7 @@ import {
   Observer,
   RuntimeJob,
 } from '../../runtime';
-import { Group } from './index';
+import type { Group } from './index';
 import { DefaultItem } from '../collection';
 import { logCodeManager } from '../../logCodeManager';