Fix false positive validation error from fragment cycle when unknown fragment is used

sogko · sogko · commit 85bc4e52e108 · 2016-04-11T17:17:18.000+08:00
Commit:
8c62789fd156761ca83992fb8d2192d41d768d13 [8c62789]
Parents:
b160c58bf5
Author:
Lee Byron &lt;lee@leebyron.com&gt;
Date:
27 October 2015 at 10:54:22 AM SGT

(Note: Already fixed previously, added a test for it)
diff --git a/rules_no_fragment_cycles_test.go b/rules_no_fragment_cycles_test.go
@@ -40,6 +40,13 @@ func TestValidate_NoCircularFragmentSpreads_DoubleSpreadWithinAbstractTypes(t *t
       }
     `)
 }
+func TestValidate_NoCircularFragmentSpreads_DoesNotFalsePositiveOnUnknownFragment(t *testing.T) {
+	testutil.ExpectPassesRule(t, graphql.NoFragmentCyclesRule, `
+      fragment nameFragment on Pet {
+        ...UnknownFragment
+      }
+    `)
+}
 func TestValidate_NoCircularFragmentSpreads_SpreadingRecursivelyWithinFieldFails(t *testing.T) {
 	testutil.ExpectFailsRule(t, graphql.NoFragmentCyclesRule, `
       fragment fragA on Human { relatives { ...fragA } },

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,13 @@ func TestValidate_NoCircularFragmentSpreads_DoubleSpreadWithinAbstractTypes(t *t`
`40`	`40`	`}`
`41`	`41`	`)
`42`	`42`	`}`
	`43`	`+func TestValidate_NoCircularFragmentSpreads_DoesNotFalsePositiveOnUnknownFragment(t *testing.T) {`
	`44`	+ testutil.ExpectPassesRule(t, graphql.NoFragmentCyclesRule, `
	`45`	`+ fragment nameFragment on Pet {`
	`46`	`+ ...UnknownFragment`
	`47`	`+ }`
	`48`	+ `)
	`49`	`+}`
`43`	`50`	`func TestValidate_NoCircularFragmentSpreads_SpreadingRecursivelyWithinFieldFails(t *testing.T) {`
`44`	`51`	testutil.ExpectFailsRule(t, graphql.NoFragmentCyclesRule, `
`45`	`52`	`fragment fragA on Human { relatives { ...fragA } },`