Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint ignore list #439

Open
steveoh opened this issue Mar 5, 2025 · 2 comments
Open

Update eslint ignore list #439

steveoh opened this issue Mar 5, 2025 · 2 comments

Comments

@steveoh
Copy link
Member

steveoh commented Mar 5, 2025

I have these in the wri app and they match the atlas template directory structure for firebase apps. What are your thoughts on if they should be added to the default? How did you come up with the current list? Does the ignore list merge with the .gitignore?

'.firebase',
'emulator_data/*',
'firebase-export-*/*',
'functions/lib/*',
'.github/*',
'data/*',
'forklift/*',
'maps/*',
'mockups/*',
'scripts/*',
@stdavis
Copy link
Member

stdavis commented Mar 6, 2025

What are your thoughts on if they should be added to the default?

My only concerns are data and scripts. I've put .js files in those folders before. But I guess that I could always explicitly include them.

How did you come up with the current list?

I think that I just copied what was in kitchen sink.

Does the ignore list merge with the .gitignore?

I don't believe so.

@steveoh
Copy link
Member Author

steveoh commented Mar 6, 2025

Good catch. This list will probably be a bit dynamic as we integrate with existing projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants