{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":439094160,"defaultBranch":"main","name":"folly","ownerLogin":"ahornby","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2021-12-16T18:46:32.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/14246801?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1721044190.0","currentOid":""},"activityList":{"items":[{"before":"99001c84c5b4540cd1ad4ad4855d5c4287ba2953","after":"37d8c32ee11f30526a80c19cde8d079745692b0c","ref":"refs/heads/main","pushedAt":"2024-07-24T09:45:27.000Z","pushType":"push","commitsCount":29,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"workaround violation of warning -Waddress under gcc\n\nReviewed By: dmm-fb\n\nDifferential Revision: D60128766\n\nfbshipit-source-id: da13399b53eb5fcc7bf156a82b5a34a48630b488","shortMessageHtmlLink":"workaround violation of warning -Waddress under gcc"}},{"before":"16fde49900fe4beb1bbbe11d8c86ca2a024d2313","after":"99001c84c5b4540cd1ad4ad4855d5c4287ba2953","ref":"refs/heads/main","pushedAt":"2024-07-17T10:11:22.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Promote AsyncGenerator use-after-completion check\n\nSummary: Extending the protection from D58483579 against violating arbitrary code invariants to opt builds\n\nReviewed By: praihan\n\nDifferential Revision: D59780512\n\nfbshipit-source-id: c2c3169493a59df47aba045bc2e5dd144b38b8af","shortMessageHtmlLink":"Promote AsyncGenerator use-after-completion check"}},{"before":"661331d60533c2ef8e82d9650cb9f78306e12e0e","after":"16fde49900fe4beb1bbbe11d8c86ca2a024d2313","ref":"refs/heads/main","pushedAt":"2024-07-15T18:32:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"fix github CI tests on windows (#2256)\n\nSummary:\nThese were [failing on github](https://github.com/facebook/folly/actions/runs/9923539772/job/27413784313#step:43:30071)\n\n * Fix use of regex in test in FsUtilTest.cpp\n * MSVC std::current_exception() exception_ptr return values are not comparable, was breaking ExceptionTest\n * Fix lookup of executable path on windows, which was breaking SSL test\n\nPull Request resolved: https://github.com/facebook/folly/pull/2256\n\nTest Plan:\n```\npython build/fbcode_builder/getdeps.py build --src-dir=. folly\npython build/fbcode_builder/getdeps.py test folly\n```\n\nbefore, broken:\n```\n1/6 Test  https://github.com/facebook/folly/issues/941: ssl_session_test.SSLSessionTest.BasicTest ...................***Failed    0.03 sec\nNote: Google Test filter = SSLSessionTest.BasicTest\n[==========] Running 1 test from 1 test suite.\n[----------] Global test environment set-up.\n[----------] 1 test from SSLSessionTest\n[ RUN      ] SSLSessionTest.BasicTest\nunknown file: error: C++ exception with description \"boost::filesystem::read_symlink: The system cannot find the path specified [system:3]: \"/proc/self/exe\"\" thrown in SetUp().\n[  FAILED  ] SSLSessionTest.BasicTest (4 ms)\n[----------] 1 test from SSLSessionTest (4 ms total)\n\n[----------] Global test environment tear-down\n[==========] 1 test from 1 test suite ran. (4 ms total)\n[  PASSED  ] 0 tests.\n[  FAILED  ] 1 test, listed below:\n[  FAILED  ] SSLSessionTest.BasicTest\n\n 1 FAILED TEST\n\n    Start  942: ssl_session_test.SSLSessionTest.NullSessionResumptionTest\n2/6 Test  https://github.com/facebook/folly/issues/936: HHWheelTimerTest.HHWheelTimerTest.GetTimeRemaining ..........   Passed    0.06 sec\n    Start 1029: lang_exception_test.ExceptionTest.current_exception\n3/6 Test  https://github.com/facebook/folly/issues/942: ssl_session_test.SSLSessionTest.NullSessionResumptionTest ...***Failed    0.04 sec\nNote: Google Test filter = SSLSessionTest.NullSessionResumptionTest\n[==========] Running 1 test from 1 test suite.\n[----------] Global test environment set-up.\n[----------] 1 test from SSLSessionTest\n[ RUN      ] SSLSessionTest.NullSessionResumptionTest\nunknown file: error: C++ exception with description \"boost::filesystem::read_symlink: The system cannot find the path specified [system:3]: \"/proc/self/exe\"\" thrown in SetUp().\n[  FAILED  ] SSLSessionTest.NullSessionResumptionTest (6 ms)\n[----------] 1 test from SSLSessionTest (6 ms total)\n\n[----------] Global test environment tear-down\n[==========] 1 test from 1 test suite ran. (7 ms total)\n[  PASSED  ] 0 tests.\n[  FAILED  ] 1 test, listed below:\n[  FAILED  ] SSLSessionTest.NullSessionResumptionTest\n\n 1 FAILED TEST\n\n4/6 Test  https://github.com/facebook/folly/issues/839: fs_util_test.Simple.UniquePathDefaultModel ..................***Failed    0.08 sec\nNote: Google Test filter = Simple.UniquePathDefaultModel\n[==========] Running 1 test from 1 test suite.\n[----------] Global test environment set-up.\n[----------] 1 test from Simple\n[ RUN      ] Simple.UniquePathDefaultModel\n5/6 Test https://github.com/facebook/folly/issues/1029: lang_exception_test.ExceptionTest.current_exception .........***Failed    0.02 sec\nNote: Google Test filter = ExceptionTest.current_exception\n[==========] Running 1 test from 1 test suite.\n[----------] Global test environment set-up.\n[----------] 1 test from ExceptionTest\n[ RUN      ] ExceptionTest.current_exception\nD:\\a\\folly\\folly\\folly\\lang\\test\\ExceptionTest.cpp(238): error: Expected equality of these values:\n  std::current_exception()\n    Which is: 16-byte object <20-44 C1-6B 9B-01 00-00 10-44 C1-6B 9B-01 00-00>\n  folly::current_exception()\n    Which is: 16-byte object <30-3B C1-6B 9B-01 00-00 20-3B C1-6B 9B-01 00-00>\nD:\\a\\folly\\folly\\folly\\lang\\test\\ExceptionTest.cpp(247): error: Expected equality of these values:\n  std::current_exception()\n    Which is: 16-byte object <40-3F C1-6B 9B-01 00-00 30-3F C1-6B 9B-01 00-00>\n  folly::current_exception()\n    Which is: 16-byte object <20-44 C1-6B 9B-01 00-00 10-44 C1-6B 9B-01 00-00>\n[  FAILED  ] ExceptionTest.current_exception (0 ms)\n[----------] 1 test from ExceptionTest (0 ms total)\n\n[----------] Global test environment tear-down\n[==========] 1 test from 1 test suite ran. (0 ms total)\n[  PASSED  ] 0 tests.\n[  FAILED  ] 1 test, listed below:\n[  FAILED  ] ExceptionTest.current_exception\n\n 1 FAILED TEST\n\n6/6 Test  https://github.com/facebook/folly/issues/838: fs_util_test.Simple.UniquePath ..............................***Failed    0.12 sec\nNote: Google Test filter = Simple.UniquePath\n[==========] Running 1 test from 1 test suite.\n[----------] Global test environment set-up.\n[----------] 1 test from Simple\n[ RUN      ] Simple.UniquePath\n```\n\nAfter, works:\n```\n1920/1920 Test  https://github.com/facebook/folly/issues/813: parallel_test.ParallelTest.PSum ......................................................................   Passed   66.92 sec\n\n100% tests passed, 0 tests failed out of 1919\n\nTotal Test time (real) =  67.02 sec\n\nThe following tests did not run:\n        1348 - atomic_unordered_map_test.AtomicUnorderedInsertMap.MegaMap (Disabled)\n```\n\nReviewed By: ndmitchell\n\nDifferential Revision: D59751594\n\nPulled By: ahornby\n\nfbshipit-source-id: 6822abeb3ab73abd4643c2c680855f8f7ba61dbb","shortMessageHtmlLink":"fix github CI tests on windows (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2408541235\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/folly/issues/2256\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/folly/pull/2256/hovercard\" href=\"https://github.com/facebook/folly/pull/2256\">facebook#2256</a>)"}},{"before":null,"after":"8d62476fbf1105380ed13d58bcaf3340c08355c4","ref":"refs/heads/fix_windows_tests","pushedAt":"2024-07-15T11:49:50.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"fix github CI tests on windows\n\nSummary:\n\nThese were [failing on github](https://github.com/facebook/folly/actions/runs/9923539772/job/27413784313#step:43:30071)\n\n * Fix use of regex in test in FsUtilTest.cpp\n * Treat MSVC like APPLE in folly::current_exception() to fix ExceptionTest\n * Fix lookup of executable path on windows, which was breaking SSL test\n\nTest Plan:\n```\npython build/fbcode_builder/getdeps.py build --src-dir=. folly\npython build/fbcode_builder/getdeps.py test folly\n```\n\nbefore, broken:\n```\n1/6 Test  #941: ssl_session_test.SSLSessionTest.BasicTest ...................***Failed    0.03 sec\nNote: Google Test filter = SSLSessionTest.BasicTest\n[==========] Running 1 test from 1 test suite.\n[----------] Global test environment set-up.\n[----------] 1 test from SSLSessionTest\n[ RUN      ] SSLSessionTest.BasicTest\nunknown file: error: C++ exception with description \"boost::filesystem::read_symlink: The system cannot find the path specified [system:3]: \"/proc/self/exe\"\" thrown in SetUp().\n[  FAILED  ] SSLSessionTest.BasicTest (4 ms)\n[----------] 1 test from SSLSessionTest (4 ms total)\n\n[----------] Global test environment tear-down\n[==========] 1 test from 1 test suite ran. (4 ms total)\n[  PASSED  ] 0 tests.\n[  FAILED  ] 1 test, listed below:\n[  FAILED  ] SSLSessionTest.BasicTest\n\n 1 FAILED TEST\n\n    Start  942: ssl_session_test.SSLSessionTest.NullSessionResumptionTest\n2/6 Test  #936: HHWheelTimerTest.HHWheelTimerTest.GetTimeRemaining ..........   Passed    0.06 sec\n    Start 1029: lang_exception_test.ExceptionTest.current_exception\n3/6 Test  #942: ssl_session_test.SSLSessionTest.NullSessionResumptionTest ...***Failed    0.04 sec\nNote: Google Test filter = SSLSessionTest.NullSessionResumptionTest\n[==========] Running 1 test from 1 test suite.\n[----------] Global test environment set-up.\n[----------] 1 test from SSLSessionTest\n[ RUN      ] SSLSessionTest.NullSessionResumptionTest\nunknown file: error: C++ exception with description \"boost::filesystem::read_symlink: The system cannot find the path specified [system:3]: \"/proc/self/exe\"\" thrown in SetUp().\n[  FAILED  ] SSLSessionTest.NullSessionResumptionTest (6 ms)\n[----------] 1 test from SSLSessionTest (6 ms total)\n\n[----------] Global test environment tear-down\n[==========] 1 test from 1 test suite ran. (7 ms total)\n[  PASSED  ] 0 tests.\n[  FAILED  ] 1 test, listed below:\n[  FAILED  ] SSLSessionTest.NullSessionResumptionTest\n\n 1 FAILED TEST\n\n4/6 Test  #839: fs_util_test.Simple.UniquePathDefaultModel ..................***Failed    0.08 sec\nNote: Google Test filter = Simple.UniquePathDefaultModel\n[==========] Running 1 test from 1 test suite.\n[----------] Global test environment set-up.\n[----------] 1 test from Simple\n[ RUN      ] Simple.UniquePathDefaultModel\n5/6 Test #1029: lang_exception_test.ExceptionTest.current_exception .........***Failed    0.02 sec\nNote: Google Test filter = ExceptionTest.current_exception\n[==========] Running 1 test from 1 test suite.\n[----------] Global test environment set-up.\n[----------] 1 test from ExceptionTest\n[ RUN      ] ExceptionTest.current_exception\nD:\\a\\folly\\folly\\folly\\lang\\test\\ExceptionTest.cpp(238): error: Expected equality of these values:\n  std::current_exception()\n    Which is: 16-byte object <20-44 C1-6B 9B-01 00-00 10-44 C1-6B 9B-01 00-00>\n  folly::current_exception()\n    Which is: 16-byte object <30-3B C1-6B 9B-01 00-00 20-3B C1-6B 9B-01 00-00>\nD:\\a\\folly\\folly\\folly\\lang\\test\\ExceptionTest.cpp(247): error: Expected equality of these values:\n  std::current_exception()\n    Which is: 16-byte object <40-3F C1-6B 9B-01 00-00 30-3F C1-6B 9B-01 00-00>\n  folly::current_exception()\n    Which is: 16-byte object <20-44 C1-6B 9B-01 00-00 10-44 C1-6B 9B-01 00-00>\n[  FAILED  ] ExceptionTest.current_exception (0 ms)\n[----------] 1 test from ExceptionTest (0 ms total)\n\n[----------] Global test environment tear-down\n[==========] 1 test from 1 test suite ran. (0 ms total)\n[  PASSED  ] 0 tests.\n[  FAILED  ] 1 test, listed below:\n[  FAILED  ] ExceptionTest.current_exception\n\n 1 FAILED TEST\n\n6/6 Test  #838: fs_util_test.Simple.UniquePath ..............................***Failed    0.12 sec\nNote: Google Test filter = Simple.UniquePath\n[==========] Running 1 test from 1 test suite.\n[----------] Global test environment set-up.\n[----------] 1 test from Simple\n[ RUN      ] Simple.UniquePath\n```\n\nAfter, works:\n```\n1920/1920 Test  #813: parallel_test.ParallelTest.PSum ......................................................................   Passed   66.92 sec\n\n100% tests passed, 0 tests failed out of 1919\n\nTotal Test time (real) =  67.02 sec\n\nThe following tests did not run:\n        1348 - atomic_unordered_map_test.AtomicUnorderedInsertMap.MegaMap (Disabled)\n```","shortMessageHtmlLink":"fix github CI tests on windows"}},{"before":"b59f99e724af79721190cf8d06be62b10c72f8e9","after":"661331d60533c2ef8e82d9650cb9f78306e12e0e","ref":"refs/heads/main","pushedAt":"2024-07-15T10:02:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"folly: fix github ci tests on macos arm (#2253)\n\nSummary:\nThese were [failing on github](https://github.com/facebook/folly/actions/runs/9923539774/job/27413784309#step:48:6919)\n\nI think the problem was the macos runner changed from intel to arm, expectations needed updating for arm.\n\nPull Request resolved: https://github.com/facebook/folly/pull/2253\n\nTest Plan:\n```\n./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. folly\n\n./build/fbcode_builder/getdeps.py --allow-system-packages --no-facebook-internal test --no-testpilot folly\n```\n\nBefore, broken\n```\n+ /opt/homebrew/opt/cmake/bin/ctest \\\n+      --output-on-failure \\\n+      -j \\\n+      3 \\\n+      --rerun-failed\nTest project /private/var/folders/xz/lz5thm6s3vb1vdkk77vmkgbr0000gn/T/fbcode_builder_getdeps-ZUsersZrunnerZworkZfollyZfollyZbuildZfbcode_builder/build/folly\n    Start 1646: arena_test.Arena.SizeSanity\n    Start 2039: constexpr_math_test.ConstexprMathTest.constexpr_exp_floating\n1/2 Test #1646: arena_test.Arena.SizeSanity ....................................***Failed    0.01 sec\nNote: Google Test filter = Arena.SizeSanity\n[==========] Running 1 test from 1 test suite.\n[----------] Global test environment set-up.\n[----------] 1 test from Arena\n[ RUN      ] Arena.SizeSanity\n/Users/runner/work/folly/folly/folly/memory/test/ArenaTest.cpp:81: Failure\nExpected: (arena.totalSize()) <= (maximum_size), actual: 1544 vs 1536\n\n/Users/runner/work/folly/folly/folly/memory/test/ArenaTest.cpp:91: Failure\nExpected: (arena.totalSize()) <= (maximum_size), actual: 1544 vs 1536\n\n[  FAILED  ] Arena.SizeSanity (0 ms)\n[----------] 1 test from Arena (0 ms total)\n\n[----------] Global test environment tear-down\n[==========] 1 test from 1 test suite ran. (0 ms total)\n[  PASSED  ] 0 tests.\n[  FAILED  ] 1 test, listed below:\n[  FAILED  ] Arena.SizeSanity\n\n 1 FAILED TEST\n\n2/2 Test https://github.com/facebook/folly/issues/2039: constexpr_math_test.ConstexprMathTest.constexpr_exp_floating ...***Failed    0.01 sec\nNote: Google Test filter = ConstexprMathTest.constexpr_exp_floating\n[==========] Running 1 test from 1 test suite.\n[----------] Global test environment set-up.\n[----------] 1 test from ConstexprMathTest\n[ RUN      ] ConstexprMathTest.constexpr_exp_floating\n/Users/runner/work/folly/folly/folly/test/ConstexprMathTest.cpp:990: Failure\nExpected equality of these values:\n  std::exp(471.L)\n    Which is: 3.5702693074778485e+204\n  a\n    Which is: 3.5702693074778518e+204\n\n[  FAILED  ] ConstexprMathTest.constexpr_exp_floating (0 ms)\n[----------] 1 test from ConstexprMathTest (0 ms total)\n\n[----------] Global test environment tear-down\n[==========] 1 test from 1 test suite ran. (0 ms total)\n[  PASSED  ] 0 tests.\n[  FAILED  ] 1 test, listed below:\n[  FAILED  ] ConstexprMathTest.constexpr_exp_floating\n\n 1 FAILED TEST\n\n0% tests passed, 2 tests failed out of 2\n\nTotal Test time (real) =   0.13 sec\n\nThe following tests FAILED:\n\t1646 - arena_test.Arena.SizeSanity (Failed)\n\t2039 - constexpr_math_test.ConstexprMathTest.constexpr_exp_floating (Failed)\n```\n\nAfter, works:\n```\n...\n3067/3067 Test https://github.com/facebook/folly/issues/2213: fbstring_test.FBString.testFixedBugsD4355440 .........................................................***Skipped   0.03 sec\n\n100% tests passed, 0 tests failed out of 3066\n\nTotal Test time (real) =  36.02 sec\n\nThe following tests did not run:\n\t1934 - small_locks_test.SmallLocks.PicoSpinLockThreadSanitizer (Skipped)\n\t1946 - small_locks_test.SmallLocksk.MicroSpinLockThreadSanitizer (Skipped)\n\t1993 - atomic_unordered_map_test.AtomicUnorderedInsertMap.MegaMap (Disabled)\n\t2213 - fbstring_test.FBString.testFixedBugsD4355440 (Skipped)\n```\n\nReviewed By: ndmitchell\n\nDifferential Revision: D59733599\n\nPulled By: ahornby\n\nfbshipit-source-id: e7f00184e867a5bf296836ea8c4a4f2430d9635a","shortMessageHtmlLink":"folly: fix github ci tests on macos arm (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2407473949\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/folly/issues/2253\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/folly/pull/2253/hovercard\" href=\"https://github.com/facebook/folly/pull/2253\">facebook#2253</a>)"}},{"before":null,"after":"762cbfcbcce9b864e529b45a77f1f2250dd3e478","ref":"refs/heads/fix_macos_arm_tests","pushedAt":"2024-07-14T15:02:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"folly: fix tests on macos arm\n\nSummary:\n\nThese were failing on github: https://github.com/facebook/folly/actions/runs/9923539774/job/27413784309#step:48:6919\n\nFix them\n\nTest Plan:\n\n```\n./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. folly\n\n./build/fbcode_builder/getdeps.py --allow-system-packages --no-facebook-internal test --no-testpilot folly\n```","shortMessageHtmlLink":"folly: fix tests on macos arm"}},{"before":"2d9c0a3c720238ae2ef1337348b6a72778024961","after":"b59f99e724af79721190cf8d06be62b10c72f8e9","ref":"refs/heads/main","pushedAt":"2024-07-14T14:14:38.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Move io_tests to folly/io/async/test\n\nSummary:\nThe following targets were moved to folly/io/async/test:\n```\n//folly/experimental/io/test:io_test_temp_file_util_lib\n//folly/experimental/io/test:async_base_test_lib\n//folly/experimental/io/test:mux_io_thread_pool_executor_test_lib\n//folly/experimental/io/test:mux_io_thread_pool_executor_test_epoll\n//folly/experimental/io/test:mux_io_thread_pool_executor_test_epoll_rearm_inline\n//folly/experimental/io/test:mux_io_thread_pool_executor_test_io_uring\n```\n\n`arc f` was applied\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\np:meitexc.folly\n\nReviewed By: dtolnay\n\nDifferential Revision: D59712373\n\nfbshipit-source-id: f49ace8c4431d41db2e42c0a306ef19192b90fb4","shortMessageHtmlLink":"Move io_tests to folly/io/async/test"}},{"before":"ec9e8d8f33f70c52b0be71407149b709f50a02f9","after":"2d9c0a3c720238ae2ef1337348b6a72778024961","ref":"refs/heads/main","pushedAt":"2024-07-13T11:45:50.000Z","pushType":"push","commitsCount":26,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Move experimental/symbolizer/{tool,test} to debugging/symbolizer\n\nSummary: tsia\n\nDifferential Revision: D59683961\n\nfbshipit-source-id: 53bb2df85f6e1189143a57c88e0bf88fea3cd3da","shortMessageHtmlLink":"Move experimental/symbolizer/{tool,test} to debugging/symbolizer"}},{"before":"7e04ec74decce5cf59127c455056296c131d4c07","after":"ec9e8d8f33f70c52b0be71407149b709f50a02f9","ref":"refs/heads/main","pushedAt":"2024-07-03T14:39:11.000Z","pushType":"push","commitsCount":95,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Make Polly work with MSVC\n\nSummary: MSVC fails to deduce template parameter for a `get` call when the argument is inherited from `std::tuple`. Workaround this by converting the argument to tuple explicitly.\n\nReviewed By: Orvid\n\nDifferential Revision: D59301411\n\nfbshipit-source-id: 61128b4599a78887ad52f6db6a1ff30e0f70df28","shortMessageHtmlLink":"Make Polly work with MSVC"}},{"before":"4db31bf3f1557698be440981e5fea8b3d5bb427f","after":"7e04ec74decce5cf59127c455056296c131d4c07","ref":"refs/heads/main","pushedAt":"2024-06-16T21:48:35.000Z","pushType":"push","commitsCount":58,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"EventBase::runAfterLoop()\n\nSummary:\nThere is a pattern of using `runInLoop()` with `thisIteration=true` to schedule a callback as late as possible in the loop and use it to batch-flush operations that were deferred by other callbacks.\n\nThis pattern may not behave as intended with `loopCallbacksTimeslice` because the scheduled callback is not guaranteed anymore to run within the same iteration.\n\nThis diff adds first-class support for the pattern with `runAfterLoop()` (symmetrical to `runBeforeLoop()`), which is guaranteed to run after the `runInLoop()` callbacks (so no rescheduling hacks needed), and is not subject to the timeslice (so it must be used with care).\n\nIt nicely complements `loopCallbacksTimeslice` for the aforementioned flush pattern, since it is possible to bound how long operations are deferred (modulo individually long-running callbacks).\n\nDifferential Revision: D58610940\n\nfbshipit-source-id: ac7ba212f18fc3750d42242daf6ba699cdb5db87","shortMessageHtmlLink":"EventBase::runAfterLoop()"}},{"before":"36780dfdedff674ab85002c8d1d860087f76bb7d","after":"48f477674935c6b1c56147a8c3e1e169437fb392","ref":"refs/heads/sapling-pr-archive-ahornby","pushedAt":"2024-06-08T14:01:21.000Z","pushType":"push","commitsCount":507,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"merge commit for archive created by Sapling","shortMessageHtmlLink":"merge commit for archive created by Sapling"}},{"before":null,"after":"b9b4722e138b7a9f7ffe7e08cb391aa4ac8b5e73","ref":"refs/heads/pr2231","pushedAt":"2024-06-08T14:01:18.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"[getdeps] restore rpm system deps for fedora\n\nSummary:\n\ncentOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855.  Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers.\n\nLets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely.\n\nAlso:\n   * fedora has up to date gtest & gmock, so use them\n   * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names.  F37 is EOL\n\nTest Plan:\n\nBuild locally on fedora 40:\n```\n./build/fbcode_builder/getdeps.py install-system-deps --recursive folly\n./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. folly\n```","shortMessageHtmlLink":"[getdeps] restore rpm system deps for fedora"}},{"before":"4986fedc20f57be5b0b0067ad1ff97cf63561d4c","after":"4db31bf3f1557698be440981e5fea8b3d5bb427f","ref":"refs/heads/main","pushedAt":"2024-06-08T11:04:11.000Z","pushType":"push","commitsCount":79,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Apply ECN bit mask when applying ECN marking on Windows\n\nSummary: Attempting to mark higher ToS values in the IP_ECN cmsg on windows results in a write error. This ensure we only set the ecn bits in the cmsg.\n\nReviewed By: mjoras\n\nDifferential Revision: D58219970\n\nfbshipit-source-id: 3e59bd1ed3ea25247c41241a9591da80099c575a","shortMessageHtmlLink":"Apply ECN bit mask when applying ECN marking on Windows"}},{"before":"465fc704da2c62a762689860c56090dd21860e73","after":"9b2a877e44f980724882050d149c4658b4afc40f","ref":"refs/heads/export-D57967014","pushedAt":"2024-05-30T16:54:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"enable more brew system deps\n\nSummary: Save a bit of time on each github build. Enable homebrew system deps for fmt, gflags, glog, googletest, snappy\n\nDifferential Revision: D57967014","shortMessageHtmlLink":"enable more brew system deps"}},{"before":null,"after":"465fc704da2c62a762689860c56090dd21860e73","ref":"refs/heads/export-D57967014","pushedAt":"2024-05-30T16:49:38.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"enable more brew system deps\n\nSummary:\nX-link: https://github.com/facebookincubator/zstrong/pull/844\n\nSave a bit of time on each github build. Enable homebrew system deps for fmt, gflags, glog, googletest, snappy\n\nDifferential Revision: D57967014","shortMessageHtmlLink":"enable more brew system deps"}},{"before":"5264efd03ebf2430b1b62c820e8706174d108cd2","after":"b13758b25baecaa2155c6e9b2f567eca058ea6c5","ref":"refs/heads/fix_linux_ci","pushedAt":"2024-05-30T09:55:54.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"[getdeps] restore rpm system deps for fedora\n\nSummary:\n\ncentOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855.  Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers.\n\nLets renable rpm deps but specify distro=fedora to reduce the risk of people removing them entirely.\n\nAlso:\n   * fedora has up to date gtest & gmock, so use them\n   * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names.  F37 is EOL\n\nTest Plan:\n\nBuild locally on fedora 40:\n```\n./build/fbcode_builder/getdeps.py install-system-deps --recursive folly\n./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. folly\n```","shortMessageHtmlLink":"[getdeps] restore rpm system deps for fedora"}},{"before":"1ade2a0604d543bb65ced81d54324ab50d8179b9","after":"4986fedc20f57be5b0b0067ad1ff97cf63561d4c","ref":"refs/heads/main","pushedAt":"2024-05-30T09:52:44.000Z","pushType":"push","commitsCount":14,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Deshim EventCount in folly\n\nSummary:\nThe following rules were deshimmed:\n```\n//folly/experimental:event_count -> //folly/synchronization:event_count\n```\n\nThe following headers were deshimmed:\n```\nfolly/experimental/EventCount.h -> folly/synchronization/EventCount.h\n```\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\nReviewed By: Orvid\n\nDifferential Revision: D57683794\n\nfbshipit-source-id: ddcb7a52d72a6fab659263ea422455e1210a2364","shortMessageHtmlLink":"Deshim EventCount in folly"}},{"before":"945a193fcd15edaf83956bfad2f6a9a149fda6bb","after":"1ade2a0604d543bb65ced81d54324ab50d8179b9","ref":"refs/heads/main","pushedAt":"2024-05-29T08:54:17.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Disable unreachable code warning in folly::expected::thenOrThrow_() in MSVC\n\nSummary:\nIn a similar vein to D55028245, the thenOrThrow_() functions in folly::expected are causing unreachable code warnings in MSVC which block compilation in builds that treat warnings as errors.\n````\nxplat\\folly\\Expected.h(711) : error C2220: the following warning is treated as an error\nxplat\\folly\\Expected.h(711) : warning C4702: unreachable code\nxplat\\folly\\Expected.h(711) : warning C4702: unreachable code\nxplat\\folly\\Expected.h(711) : warning C4702: unreachable code\n````\n\nThis happens only in MSVC when a caller uses a folly::expected::as{Type}() function where the compiler knows through optimization that the expected will always hold a valid value (thus the exception-throwing code can never be reached).  Issuing a warning in this case seems to be an overreach by the MSVC compiler but apparently is by-design.\n\nThis is forcing HSR to add warning disable pragmas anywhere that folly::dynamic is used as it triggers these warnings.  Better to fix the warning at the source so it doesn't keep biting us.\n\nReviewed By: Orvid\n\nDifferential Revision: D57844817\n\nfbshipit-source-id: 60dba228788dbd1b47d71382b4487b7cc1440dd1","shortMessageHtmlLink":"Disable unreachable code warning in folly::expected::thenOrThrow_() i…"}},{"before":"a53ef85eb2cd762b64faefd92547b47681ca7a1a","after":"945a193fcd15edaf83956bfad2f6a9a149fda6bb","ref":"refs/heads/main","pushedAt":"2024-05-25T14:39:10.000Z","pushType":"push","commitsCount":81,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Introduce reserve_if_available\n\nSummary:\nThis is useful when writing generic code that handles containers.  Some examples:\n- std::unordered_map provides reserve(), but std::map does not\n- std::vector provides reserve(), but std::deque and std::list do not\n\nReviewed By: yfeldblum\n\nDifferential Revision: D57718859\n\nfbshipit-source-id: 9cb146b2950746e416c938b0cc6484715f58bb69","shortMessageHtmlLink":"Introduce reserve_if_available"}},{"before":null,"after":"ec19ac4fac0c489e2f0e9e5b17e421e1113c2952","ref":"refs/heads/fedora_rpms","pushedAt":"2024-05-11T12:30:58.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"[getdeps] fix --shared-libs boost linkage\n\nSummary:\nFolly getdeps builds are linking to static boost libs in shared mode, which causes link failure. Fix it\n\nTest Plan:\n\nLocal build with:`./build/fbcode_builder/getdeps.py --allow-system-packages build --shared-libs --src-dir=. folly`\n\nBefore, fails when it tries linking to the boost .a archives: ```\n[380/951] Linking CXX shared library libfolly.so.0.58.0-dev\nFAILED: libfolly.so.0.58.0-dev\n: && /usr/bin/c++ -fPIC -O2 -g -DNDEBUG   -shared -Wl,-soname,libfolly.so.0.58.0-dev -o libfolly.so.0.58.0-dev CMakeFiles/folly_base.dir/folly/CancellationToken.cpp.o CMakeFiles/folly_base.dir/folly/ClockGettimeWrappers.cpp.o CMakeFiles/folly_base.dir/folly/Conv.cpp.o CMakeFiles/folly_base.dir/folly/Demangle.cpp.o CMakeFiles/folly_base.dir/folly/ExceptionString.cpp.o CMakeFiles/folly_base.dir/folly/ExceptionWrapper.cpp.o CMakeFiles/folly_base.dir/folly/Executor.cpp.o CMakeFiles/folly_base.dir/folly/File.cpp.o CMakeFiles/folly_base.dir/folly/FileUtil.cpp.o CMakeFiles/folly_base.dir/folly/Fingerprint.cpp.o CMakeFiles/folly_base.dir/folly/FollyMemcpy.cpp.o CMakeFiles/folly_base.dir/folly/FollyMemset.cpp.o CMakeFiles/folly_base.dir/folly/Format.cpp.o CMakeFiles/folly_base.dir/folly/GroupVarint.cpp.o CMakeFiles/folly_base.dir/folly/IPAddress.cpp.o CMakeFiles/folly_base.dir/folly/IPAddressV4.cpp.o CMakeFiles/folly_base.dir/folly/IPAddressV6.cpp.o CMakeFiles/folly_base.dir/folly/MacAddress.cpp.o CMakeFiles/folly_base.dir/folly/MicroLock.cpp.o CMakeFiles/folly_base.dir/folly/Random.cpp.o CMakeFiles/folly_base.dir/folly/ScopeGuard.cpp.o CMakeFiles/folly_base.dir/folly/SharedMutex.cpp.o CMakeFiles/folly_base.dir/folly/Singleton.cpp.o CMakeFiles/folly_base.dir/folly/SingletonThreadLocal.cpp.o CMakeFiles/folly_base.dir/folly/SocketAddress.cpp.o CMakeFiles/folly_base.dir/folly/String.cpp.o CMakeFiles/folly_base.dir/folly/Subprocess.cpp.o CMakeFiles/folly_base.dir/folly/TimeoutQueue.cpp.o CMakeFiles/folly_base.dir/folly/Try.cpp.o CMakeFiles/folly_base.dir/folly/Unicode.cpp.o CMakeFiles/folly_base.dir/folly/Uri.cpp.o CMakeFiles/folly_base.dir/folly/channels/MaxConcurrentRateLimiter.cpp.o CMakeFiles/folly_base.dir/folly/cli/NestedCommandLineApp.cpp.o CMakeFiles/folly_base.dir/folly/cli/ProgramOptions.cpp.o CMakeFiles/folly_base.dir/folly/compression/Compression.cpp.o CMakeFiles/folly_base.dir/folly/compression/CompressionContextPoolSingletons.cpp.o CMakeFiles/folly_base.dir/folly/compression/Zlib.cpp.o CMakeFiles/folly_base.dir/folly/compression/Zstd.cpp.o CMakeFiles/folly_base.dir/folly/concurrency/CacheLocality.cpp.o CMakeFiles/folly_base.dir/folly/concurrency/DeadlockDetector.cpp.o CMakeFiles/folly_base.dir/folly/concurrency/ProcessLocalUniqueId.cpp.o CMakeFiles/folly_base.dir/folly/container/detail/F14Table.cpp.o CMakeFiles/folly_base.dir/folly/detail/AsyncTrace.cpp.o CMakeFiles/folly_base.dir/folly/detail/FileUtilDetail.cpp.o CMakeFiles/folly_base.dir/folly/detail/Futex.cpp.o CMakeFiles/folly_base.dir/folly/detail/IPAddress.cpp.o CMakeFiles/folly_base.dir/folly/detail/MemoryIdler.cpp.o CMakeFiles/folly_base.dir/folly/detail/PerfScoped.cpp.o CMakeFiles/folly_base.dir/folly/detail/RangeCommon.cpp.o CMakeFiles/folly_base.dir/folly/detail/RangeSse42.cpp.o CMakeFiles/folly_base.dir/folly/detail/SimpleSimdStringUtils.cpp.o CMakeFiles/folly_base.dir/folly/detail/SocketFastOpen.cpp.o CMakeFiles/folly_base.dir/folly/detail/SplitStringSimd.cpp.o CMakeFiles/folly_base.dir/folly/detail/Sse.cpp.o CMakeFiles/folly_base.dir/folly/detail/StaticSingletonManager.cpp.o CMakeFiles/folly_base.dir/folly/detail/ThreadLocalDetail.cpp.o CMakeFiles/folly_base.dir/folly/detail/TrapOnAvx512.cpp.o CMakeFiles/folly_base.dir/folly/detail/UniqueInstance.cpp.o CMakeFiles/folly_base.dir/folly/detail/base64_detail/Base64Api.cpp.o CMakeFiles/folly_base.dir/folly/detail/base64_detail/Base64SWAR.cpp.o CMakeFiles/folly_base.dir/folly/detail/base64_detail/Base64_SSE4_2.cpp.o CMakeFiles/folly_base.dir/folly/executors/CPUThreadPoolExecutor.cpp.o CMakeFiles/folly_base.dir/folly/executors/Codel.cpp.o CMakeFiles/folly_base.dir/folly/executors/EDFThreadPoolExecutor.cpp.o CMakeFiles/folly_base.dir/folly/executors/ExecutorWithPriority.cpp.o CMakeFiles/folly_base.dir/folly/executors/GlobalExecutor.cpp.o CMakeFiles/folly_base.dir/folly/executors/GlobalThreadPoolList.cpp.o CMakeFiles/folly_base.dir/folly/executors/IOThreadPoolDeadlockDetectorObserver.cpp.o CMakeFiles/folly_base.dir/folly/executors/IOThreadPoolExecutor.cpp.o CMakeFiles/folly_base.dir/folly/executors/InlineExecutor.cpp.o CMakeFiles/folly_base.dir/folly/executors/ManualExecutor.cpp.o CMakeFiles/folly_base.dir/folly/executors/QueueObserver.cpp.o CMakeFiles/folly_base.dir/folly/executors/QueuedImmediateExecutor.cpp.o CMakeFiles/folly_base.dir/folly/executors/SoftRealTimeExecutor.cpp.o CMakeFiles/folly_base.dir/folly/executors/StrandExecutor.cpp.o CMakeFiles/folly_base.dir/folly/executors/ThreadPoolExecutor.cpp.o CMakeFiles/folly_base.dir/folly/executors/ThreadedExecutor.cpp.o CMakeFiles/folly_base.dir/folly/executors/TimedDrivableExecutor.cpp.o CMakeFiles/folly_base.dir/folly/executors/TimekeeperScheduledExecutor.cpp.o CMakeFiles/folly_base.dir/folly/executors/thread_factory/PriorityThreadFactory.cpp.o CMakeFiles/folly_base.dir/folly/experimental/AtomicReadMostlyMainPtr.cpp.o CMakeFiles/folly_base.dir/folly/experimental/ExecutionObserver.cpp.o CMakeFiles/folly_base.dir/folly/experimental/FunctionScheduler.cpp.o CMakeFiles/folly_base.dir/folly/experimental/QuotientMultiSet.cpp.o CMakeFiles/folly_base.dir/folly/experimental/STTimerFDTimeoutManager.cpp.o CMakeFiles/folly_base.dir/folly/experimental/Select64.cpp.o CMakeFiles/folly_base.dir/folly/experimental/TestUtil.cpp.o CMakeFiles/folly_base.dir/folly/experimental/ThreadedRepeatingFunctionRunner.cpp.o CMakeFiles/folly_base.dir/folly/experimental/TimerFD.cpp.o CMakeFiles/folly_base.dir/folly/experimental/TimerFDTimeoutManager.cpp.o CMakeFiles/folly_base.dir/folly/experimental/coro/Baton.cpp.o CMakeFiles/folly_base.dir/folly/experimental/coro/Mutex.cpp.o CMakeFiles/folly_base.dir/folly/experimental/coro/SharedMutex.cpp.o CMakeFiles/folly_base.dir/folly/experimental/coro/detail/Malloc.cpp.o CMakeFiles/folly_base.dir/folly/experimental/crypto/Blake2xb.cpp.o CMakeFiles/folly_base.dir/folly/experimental/crypto/LtHash.cpp.o CMakeFiles/folly_base.dir/folly/experimental/crypto/detail/MathOperation_AVX2.cpp.o CMakeFiles/folly_base.dir/folly/experimental/crypto/detail/MathOperation_SSE2.cpp.o CMakeFiles/folly_base.dir/folly/experimental/crypto/detail/MathOperation_Simple.cpp.o CMakeFiles/folly_base.dir/folly/experimental/exception_tracer/ExceptionCounterLib.cpp.o CMakeFiles/folly_base.dir/folly/experimental/exception_tracer/ExceptionStackTraceLib.cpp.o CMakeFiles/folly_base.dir/folly/experimental/exception_tracer/ExceptionTracer.cpp.o CMakeFiles/folly_base.dir/folly/experimental/exception_tracer/ExceptionTracerLib.cpp.o CMakeFiles/folly_base.dir/folly/experimental/exception_tracer/SmartExceptionStackTraceHooks.cpp.o CMakeFiles/folly_base.dir/folly/experimental/exception_tracer/SmartExceptionTracer.cpp.o CMakeFiles/folly_base.dir/folly/experimental/exception_tracer/SmartExceptionTracerSingleton.cpp.o CMakeFiles/folly_base.dir/folly/experimental/exception_tracer/StackTrace.cpp.o CMakeFiles/folly_base.dir/folly/experimental/io/AsyncBase.cpp.o CMakeFiles/folly_base.dir/folly/experimental/io/AsyncIO.cpp.o CMakeFiles/folly_base.dir/folly/experimental/io/AsyncIoUringSocket.cpp.o CMakeFiles/folly_base.dir/folly/experimental/io/EpollBackend.cpp.o CMakeFiles/folly_base.dir/folly/experimental/io/EventBasePoller.cpp.o CMakeFiles/folly_base.dir/folly/experimental/io/FsUtil.cpp.o CMakeFiles/folly_base.dir/folly/experimental/io/HugePages.cpp.o CMakeFiles/folly_base.dir/folly/experimental/io/IoUring.cpp.o CMakeFiles/folly_base.dir/folly/experimental/io/IoUringBackend.cpp.o CMakeFiles/folly_base.dir/folly/experimental/io/IoUringEvent.cpp.o CMakeFiles/folly_base.dir/folly/experimental/io/IoUringEventBaseLocal.cpp.o CMakeFiles/folly_base.dir/folly/experimental/io/IoUringProvidedBufferRing.cpp.o CMakeFiles/folly_base.dir/folly/experimental/io/MuxIOThreadPoolExecutor.cpp.o CMakeFiles/folly_base.dir/folly/experimental/io/SimpleAsyncIO.cpp.o CMakeFiles/folly_base.dir/folly/experimental/observer/detail/Core.cpp.o CMakeFiles/folly_base.dir/folly/experimental/observer/detail/ObserverManager.cpp.o CMakeFiles/folly_base.dir/folly/experimental/settings/Immutables.cpp.o CMakeFiles/folly_base.dir/folly/experimental/settings/Settings.cpp.o CMakeFiles/folly_base.dir/folly/experimental/settings/Types.cpp.o CMakeFiles/folly_base.dir/folly/experimental/symbolizer/Dwarf.cpp.o CMakeFiles/folly_base.dir/folly/experimental/symbolizer/DwarfImpl.cpp.o CMakeFiles/folly_base.dir/folly/experimental/symbolizer/DwarfLineNumberVM.cpp.o CMakeFiles/folly_base.dir/folly/experimental/symbolizer/DwarfSection.cpp.o CMakeFiles/folly_base.dir/folly/experimental/symbolizer/DwarfUtil.cpp.o CMakeFiles/folly_base.dir/folly/experimental/symbolizer/Elf.cpp.o CMakeFiles/folly_base.dir/folly/experimental/symbolizer/ElfCache.cpp.o CMakeFiles/folly_base.dir/folly/experimental/symbolizer/LineReader.cpp.o CMakeFiles/folly_base.dir/folly/experimental/symbolizer/SignalHandler.cpp.o CMakeFiles/folly_base.dir/folly/experimental/symbolizer/StackTrace.cpp.o CMakeFiles/folly_base.dir/folly/experimental/symbolizer/SymbolizePrinter.cpp.o CMakeFiles/folly_base.dir/folly/experimental/symbolizer/SymbolizedFrame.cpp.o CMakeFiles/folly_base.dir/folly/experimental/symbolizer/Symbolizer.cpp.o CMakeFiles/folly_base.dir/folly/ext/test_ext.cpp.o CMakeFiles/folly_base.dir/folly/external/farmhash/farmhash.cpp.o CMakeFiles/folly_base.dir/folly/external/fast-crc32/avx512_crc32c_v8s3x4.cpp.o CMakeFiles/folly_base.dir/folly/external/fast-crc32/sse_crc32c_v8s3x3.cpp.o CMakeFiles/folly_base.dir/folly/fibers/BatchSemaphore.cpp.o CMakeFiles/folly_base.dir/folly/fibers/Baton.cpp.o CMakeFiles/folly_base.dir/folly/fibers/Fiber.cpp.o CMakeFiles/folly_base.dir/folly/fibers/FiberManager.cpp.o CMakeFiles/folly_base.dir/folly/fibers/GuardPageAllocator.cpp.o CMakeFiles/folly_base.dir/folly/fibers/Semaphore.cpp.o CMakeFiles/folly_base.dir/folly/fibers/SemaphoreBase.cpp.o CMakeFiles/folly_base.dir/folly/fibers/SimpleLoopController.cpp.o CMakeFiles/folly_base.dir/folly/fibers/async/Async.cpp.o CMakeFiles/folly_base.dir/folly/fibers/detail/AtomicBatchDispatcher.cpp.o CMakeFiles/folly_base.dir/folly/futures/Barrier.cpp.o CMakeFiles/folly_base.dir/folly/futures/Future.cpp.o CMakeFiles/folly_base.dir/folly/futures/HeapTimekeeper.cpp.o CMakeFiles/folly_base.dir/folly/futures/ManualTimekeeper.cpp.o CMakeFiles/folly_base.dir/folly/futures/Promise.cpp.o CMakeFiles/folly_base.dir/folly/futures/SharedPromise.cpp.o CMakeFiles/folly_base.dir/folly/futures/ThreadWheelTimekeeper.cpp.o CMakeFiles/folly_base.dir/folly/futures/detail/Core.cpp.o CMakeFiles/folly_base.dir/folly/hash/Checksum.cpp.o CMakeFiles/folly_base.dir/folly/hash/SpookyHashV1.cpp.o CMakeFiles/folly_base.dir/folly/hash/SpookyHashV2.cpp.o CMakeFiles/folly_base.dir/folly/hash/detail/ChecksumDetail.cpp.o CMakeFiles/folly_base.dir/folly/hash/detail/Crc32CombineDetail.cpp.o CMakeFiles/folly_base.dir/folly/hash/detail/Crc32cDetail.cpp.o CMakeFiles/folly_base.dir/folly/init/Init.cpp.o CMakeFiles/folly_base.dir/folly/init/Phase.cpp.o CMakeFiles/folly_base.dir/folly/io/Cursor.cpp.o CMakeFiles/folly_base.dir/folly/io/GlobalShutdownSocketSet.cpp.o CMakeFiles/folly_base.dir/folly/io/IOBuf.cpp.o CMakeFiles/folly_base.dir/folly/io/IOBufIovecBuilder.cpp.o CMakeFiles/folly_base.dir/folly/io/IOBufQueue.cpp.o CMakeFiles/folly_base.dir/folly/io/RecordIO.cpp.o CMakeFiles/folly_base.dir/folly/io/ShutdownSocketSet.cpp.o CMakeFiles/folly_base.dir/folly/io/SocketOptionMap.cpp.o CMakeFiles/folly_base.dir/folly/io/SocketOptionValue.cpp.o CMakeFiles/folly_base.dir/folly/io/async/AsyncPipe.cpp.o CMakeFiles/folly_base.dir/folly/io/async/AsyncSSLSocket.cpp.o CMakeFiles/folly_base.dir/folly/io/async/AsyncServerSocket.cpp.o CMakeFiles/folly_base.dir/folly/io/async/AsyncSignalHandler.cpp.o CMakeFiles/folly_base.dir/folly/io/async/AsyncSocket.cpp.o CMakeFiles/folly_base.dir/folly/io/async/AsyncSocketException.cpp.o CMakeFiles/folly_base.dir/folly/io/async/AsyncSocketTransport.cpp.o CMakeFiles/folly_base.dir/folly/io/async/AsyncTimeout.cpp.o CMakeFiles/folly_base.dir/folly/io/async/AsyncUDPSocket.cpp.o CMakeFiles/folly_base.dir/folly/io/async/DelayedDestruction.cpp.o CMakeFiles/folly_base.dir/folly/io/async/EventBase.cpp.o CMakeFiles/folly_base.dir/folly/io/async/EventBaseBackendBase.cpp.o CMakeFiles/folly_base.dir/folly/io/async/EventBaseLocal.cpp.o CMakeFiles/folly_base.dir/folly/io/async/EventBaseManager.cpp.o CMakeFiles/folly_base.dir/folly/io/async/EventBaseThread.cpp.o CMakeFiles/folly_base.dir/folly/io/async/EventHandler.cpp.o CMakeFiles/folly_base.dir/folly/io/async/HHWheelTimer.cpp.o CMakeFiles/folly_base.dir/folly/io/async/PasswordInFile.cpp.o CMakeFiles/folly_base.dir/folly/io/async/Request.cpp.o CMakeFiles/folly_base.dir/folly/io/async/SSLContext.cpp.o CMakeFiles/folly_base.dir/folly/io/async/SSLOptions.cpp.o CMakeFiles/folly_base.dir/folly/io/async/ScopedEventBaseThread.cpp.o CMakeFiles/folly_base.dir/folly/io/async/TerminateCancellationToken.cpp.o CMakeFiles/folly_base.dir/folly/io/async/TimeoutManager.cpp.o CMakeFiles/folly_base.dir/folly/io/async/VirtualEventBase.cpp.o CMakeFiles/folly_base.dir/folly/io/async/fdsock/AsyncFdSocket.cpp.o CMakeFiles/folly_base.dir/folly/io/async/fdsock/SocketFds.cpp.o CMakeFiles/folly_base.dir/folly/io/async/ssl/OpenSSLUtils.cpp.o CMakeFiles/folly_base.dir/folly/io/async/ssl/SSLErrors.cpp.o CMakeFiles/folly_base.dir/folly/io/coro/ServerSocket.cpp.o CMakeFiles/folly_base.dir/folly/io/coro/Transport.cpp.o CMakeFiles/folly_base.dir/folly/json/DynamicParser.cpp.o CMakeFiles/folly_base.dir/folly/json/JSONSchema.cpp.o CMakeFiles/folly_base.dir/folly/json/JsonTestUtil.cpp.o CMakeFiles/folly_base.dir/folly/json/bser/Dump.cpp.o CMakeFiles/folly_base.dir/folly/json/bser/Load.cpp.o CMakeFiles/folly_base.dir/folly/json/dynamic.cpp.o CMakeFiles/folly_base.dir/folly/json/json.cpp.o CMakeFiles/folly_base.dir/folly/json/json_patch.cpp.o CMakeFiles/folly_base.dir/folly/json/json_pointer.cpp.o CMakeFiles/folly_base.dir/folly/lang/CString.cpp.o CMakeFiles/folly_base.dir/folly/lang/Exception.cpp.o CMakeFiles/folly_base.dir/folly/lang/SafeAssert.cpp.o CMakeFiles/folly_base.dir/folly/lang/ToAscii.cpp.o CMakeFiles/folly_base.dir/folly/lang/UncaughtExceptions.cpp.o CMakeFiles/folly_base.dir/folly/logging/AsyncFileWriter.cpp.o CMakeFiles/folly_base.dir/folly/logging/AsyncLogWriter.cpp.o CMakeFiles/folly_base.dir/folly/logging/BridgeFromGoogleLogging.cpp.o CMakeFiles/folly_base.dir/folly/logging/CustomLogFormatter.cpp.o CMakeFiles/folly_base.dir/folly/logging/FileHandlerFactory.cpp.o CMakeFiles/folly_base.dir/folly/logging/FileWriterFactory.cpp.o CMakeFiles/folly_base.dir/folly/logging/GlogStyleFormatter.cpp.o CMakeFiles/folly_base.dir/folly/logging/ImmediateFileWriter.cpp.o CMakeFiles/folly_base.dir/folly/logging/Init.cpp.o CMakeFiles/folly_base.dir/folly/logging/InitWeak.cpp.o CMakeFiles/folly_base.dir/folly/logging/LogCategory.cpp.o CMakeFiles/folly_base.dir/folly/logging/LogCategoryConfig.cpp.o CMakeFiles/folly_base.dir/folly/logging/LogConfig.cpp.o CMakeFiles/folly_base.dir/folly/logging/LogConfigParser.cpp.o CMakeFiles/folly_base.dir/folly/logging/LogHandlerConfig.cpp.o CMakeFiles/folly_base.dir/folly/logging/LogLevel.cpp.o CMakeFiles/folly_base.dir/folly/logging/LogMessage.cpp.o CMakeFiles/folly_base.dir/folly/logging/LogName.cpp.o CMakeFiles/folly_base.dir/folly/logging/LogStream.cpp.o CMakeFiles/folly_base.dir/folly/logging/LogStreamProcessor.cpp.o CMakeFiles/folly_base.dir/folly/logging/Logger.cpp.o CMakeFiles/folly_base.dir/folly/logging/LoggerDB.cpp.o CMakeFiles/folly_base.dir/folly/logging/ObjectToString.cpp.o CMakeFiles/folly_base.dir/folly/logging/RateLimiter.cpp.o CMakeFiles/folly_base.dir/folly/logging/StandardLogHandler.cpp.o CMakeFiles/folly_base.dir/folly/logging/StandardLogHandlerFactory.cpp.o CMakeFiles/folly_base.dir/folly/logging/StreamHandlerFactory.cpp.o CMakeFiles/folly_base.dir/folly/logging/xlog.cpp.o CMakeFiles/folly_base.dir/folly/memory/JemallocHugePageAllocator.cpp.o CMakeFiles/folly_base.dir/folly/memory/JemallocNodumpAllocator.cpp.o CMakeFiles/folly_base.dir/folly/memory/MallctlHelper.cpp.o CMakeFiles/folly_base.dir/folly/memory/ReentrantAllocator.cpp.o CMakeFiles/folly_base.dir/folly/memory/SanitizeAddress.cpp.o CMakeFiles/folly_base.dir/folly/memory/SanitizeLeak.cpp.o CMakeFiles/folly_base.dir/folly/memory/ThreadCachedArena.cpp.o CMakeFiles/folly_base.dir/folly/memory/detail/MallocImpl.cpp.o CMakeFiles/folly_base.dir/folly/net/NetOps.cpp.o CMakeFiles/folly_base.dir/folly/net/NetOpsDispatcher.cpp.o CMakeFiles/folly_base.dir/folly/net/TcpInfo.cpp.o CMakeFiles/folly_base.dir/folly/net/TcpInfoDispatcher.cpp.o CMakeFiles/folly_base.dir/folly/net/detail/SocketFileDescriptorMap.cpp.o CMakeFiles/folly_base.dir/folly/portability/Builtins.cpp.o CMakeFiles/folly_base.dir/folly/portability/Dirent.cpp.o CMakeFiles/folly_base.dir/folly/portability/Fcntl.cpp.o CMakeFiles/folly_base.dir/folly/portability/Filesystem.cpp.o CMakeFiles/folly_base.dir/folly/portability/Libgen.cpp.o CMakeFiles/folly_base.dir/folly/portability/Malloc.cpp.o CMakeFiles/folly_base.dir/folly/portability/OpenSSL.cpp.o CMakeFiles/folly_base.dir/folly/portability/PThread.cpp.o CMakeFiles/folly_base.dir/folly/portability/Sched.cpp.o CMakeFiles/folly_base.dir/folly/portability/Sockets.cpp.o CMakeFiles/folly_base.dir/folly/portability/Stdio.cpp.o CMakeFiles/folly_base.dir/folly/portability/Stdlib.cpp.o CMakeFiles/folly_base.dir/folly/portability/String.cpp.o CMakeFiles/folly_base.dir/folly/portability/SysFile.cpp.o CMakeFiles/folly_base.dir/folly/portability/SysMembarrier.cpp.o CMakeFiles/folly_base.dir/folly/portability/SysMman.cpp.o CMakeFiles/folly_base.dir/folly/portability/SysResource.cpp.o CMakeFiles/folly_base.dir/folly/portability/SysStat.cpp.o CMakeFiles/folly_base.dir/folly/portability/SysTime.cpp.o CMakeFiles/folly_base.dir/folly/portability/SysUio.cpp.o CMakeFiles/folly_base.dir/folly/portability/Time.cpp.o CMakeFiles/folly_base.dir/folly/portability/Unistd.cpp.o CMakeFiles/folly_base.dir/folly/ssl/OpenSSLCertUtils.cpp.o CMakeFiles/folly_base.dir/folly/ssl/OpenSSLHash.cpp.o CMakeFiles/folly_base.dir/folly/ssl/OpenSSLKeyUtils.cpp.o CMakeFiles/folly_base.dir/folly/ssl/PasswordCollector.cpp.o CMakeFiles/folly_base.dir/folly/ssl/SSLSessionManager.cpp.o CMakeFiles/folly_base.dir/folly/ssl/detail/OpenSSLSession.cpp.o CMakeFiles/folly_base.dir/folly/stats/QuantileEstimator.cpp.o CMakeFiles/folly_base.dir/folly/stats/TDigest.cpp.o CMakeFiles/folly_base.dir/folly/stats/detail/DoubleRadixSort.cpp.o CMakeFiles/folly_base.dir/folly/synchronization/AsymmetricThreadFence.cpp.o CMakeFiles/folly_base.dir/folly/synchronization/AtomicNotification.cpp.o CMakeFiles/folly_base.dir/folly/synchronization/DistributedMutex.cpp.o CMakeFiles/folly_base.dir/folly/synchronization/Hazptr.cpp.o CMakeFiles/folly_base.dir/folly/synchronization/HazptrDomain.cpp.o CMakeFiles/folly_base.dir/folly/synchronization/HazptrThreadPoolExecutor.cpp.o CMakeFiles/folly_base.dir/folly/synchronization/ParkingLot.cpp.o CMakeFiles/folly_base.dir/folly/synchronization/Rcu.cpp.o CMakeFiles/folly_base.dir/folly/synchronization/SanitizeThread.cpp.o CMakeFiles/folly_base.dir/folly/synchronization/WaitOptions.cpp.o CMakeFiles/folly_base.dir/folly/synchronization/detail/Hardware.cpp.o CMakeFiles/folly_base.dir/folly/synchronization/detail/Sleeper.cpp.o CMakeFiles/folly_base.dir/folly/system/AtFork.cpp.o CMakeFiles/folly_base.dir/folly/system/EnvUtil.cpp.o CMakeFiles/folly_base.dir/folly/system/HardwareConcurrency.cpp.o CMakeFiles/folly_base.dir/folly/system/MemoryMapping.cpp.o CMakeFiles/folly_base.dir/folly/system/Pid.cpp.o CMakeFiles/folly_base.dir/folly/system/Shell.cpp.o CMakeFiles/folly_base.dir/folly/system/ThreadId.cpp.o CMakeFiles/folly_base.dir/folly/system/ThreadName.cpp.o CMakeFiles/folly_base.dir/folly/tracing/AsyncStack.cpp.o CMakeFiles/folly_base.dir/folly/io/async/test/ScopedBoundPort.cpp.o CMakeFiles/folly_base.dir/folly/io/async/test/SocketPair.cpp.o CMakeFiles/folly_base.dir/folly/io/async/test/TimeUtil.cpp.o CMakeFiles/folly_base.dir/folly/memcpy.S.o  /usr/lib64/libfmt.so.10.2.1  /usr/lib64/libboost_context.a  /usr/lib64/libboost_filesystem.a  /usr/lib64/libboost_atomic.a  /usr/lib64/libboost_program_options.a  /usr/lib64/libboost_regex.a  -licudata  -licui18n  -licuuc  /usr/lib64/libboost_system.a  /usr/lib64/libboost_thread.a  -ldouble-conversion  /usr/lib64/libgflags.so.2.2.2  -lglog  -levent  -lz  -lssl  -lcrypto  -lbz2  -llzma  -llz4  -lzstd  -lsnappy  -ldwarf  -Wl,-Bstatic  -liberty  -Wl,-Bdynamic  -lsodium  -ldl  -lunwind && :\n/usr/bin/ld: /usr/lib64/libboost_program_options.a(value_semantic.o): warning: relocation against `_ZTIN5boost10wrapexceptINS_15program_options18invalid_bool_valueEEE' in read-only section `.text._ZNK5boost10wrapexceptINS_15program_options18invalid_bool_valueEE7rethrowEv[_ZNK5boost10wrapexceptINS_15program_options18invalid_bool_valueEE7rethrowEv]'\n/usr/bin/ld: /usr/lib64/libboost_filesystem.a(exception.o): relocation R_X86_64_PC32 against symbol `_ZTVN5boost10filesystem16filesystem_errorE' can not be used when making a shared object; recompile with -fPIC\n/usr/bin/ld: final link failed: bad value\ncollect2: error: ld returned 1 exit status\n\n```\n\nAfter, links to .so and works","shortMessageHtmlLink":"[getdeps] fix --shared-libs boost linkage"}},{"before":"7f1cf32e1b74fcc5c25d5bfc5d54e98548efe999","after":"a53ef85eb2cd762b64faefd92547b47681ca7a1a","ref":"refs/heads/main","pushedAt":"2024-05-11T09:46:45.000Z","pushType":"push","commitsCount":117,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Fix includes] fbcode/folly/io/async\n\nReviewed By: yfeldblum\n\nDifferential Revision: D56872850\n\nfbshipit-source-id: f5143e920bb5d7cefc7f9900d74976a1fda7eeb4","shortMessageHtmlLink":"Fix includes] fbcode/folly/io/async"}},{"before":"f16c79b9873e435264378367582adda546d8b593","after":"7f1cf32e1b74fcc5c25d5bfc5d54e98548efe999","ref":"refs/heads/main","pushedAt":"2024-04-16T11:59:50.000Z","pushType":"push","commitsCount":24,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Enable `JemallocHugePageAllocator` only when jemalloc is used\n\nSummary:\n`folly::JemallocHugePageAllocator` should work without explicit calls of\n`default_init` or `init` (see comment inside `allocate` method), but we check\nif we actually linked against jemalloc in `init`. When we linked against\ndifferent allocator and user code calls `JemallocHugePageAllocator::allocate`\nright away, without calling `init` first we'll get a crash.\n\nMoved `folly::usingJEMalloc()` call from constructor to\n`folly::JemallocHugePageAllocator::hugePagesSupported` initializer to have a\ncorrect value `hugePagesSupported` in any case.\n\nReviewed By: ot\n\nDifferential Revision: D56021830\n\nfbshipit-source-id: bb30c992f4e2854570c358a9ae12f234516eb479","shortMessageHtmlLink":"Enable <code>JemallocHugePageAllocator</code> only when jemalloc is used"}},{"before":"9e1fb995b8cc6168a1145b4fa4a0e232654f8531","after":null,"ref":"refs/heads/remove/windows_scoop","pushedAt":"2024-04-06T16:29:52.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"}},{"before":null,"after":"9e1fb995b8cc6168a1145b4fa4a0e232654f8531","ref":"refs/heads/windows_scoop","pushedAt":"2024-04-06T16:29:34.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"use scoop for system deps on windows\n\nSummary:\nAdd system dep support for windows so that each github CI run doesn't rebuild boost\n\nWent with scoop rather than choco, vcpkg or winget as scopp installs its packages in a way that are by default visible to cmake and visual studio build tools\n\n\nTest Plan:\n\nCheck locally what system packages would be installed\n```\npython build/fbcode_builder/getdeps.py install-system-deps --dry-run --recursive folly\n...\nscoop install versions/boost-msvc142\n```\n\nInstall locally using the suggested command\n\nCheck that local folly local build picks them up\n```\npython build/fbcode_builder/getdeps.py build --allow-system-packages --src-dir=. folly\n```\n\nRegenerate CI\n```\n# check linux and mac still ok\npython build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --free-up-disk --os-type=linux --os-type=darwin --output-dir=.github/workflows folly\n# new windows ones\npython build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --os-type=windows --output-dir=.github/workflows folly\n```\n\nFinally, let github CI run to verify that its ok when not on my machine","shortMessageHtmlLink":"use scoop for system deps on windows"}},{"before":null,"after":"9e1fb995b8cc6168a1145b4fa4a0e232654f8531","ref":"refs/heads/remove/windows_scoop","pushedAt":"2024-04-06T16:29:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"use scoop for system deps on windows\n\nSummary:\nAdd system dep support for windows so that each github CI run doesn't rebuild boost\n\nWent with scoop rather than choco, vcpkg or winget as scopp installs its packages in a way that are by default visible to cmake and visual studio build tools\n\n\nTest Plan:\n\nCheck locally what system packages would be installed\n```\npython build/fbcode_builder/getdeps.py install-system-deps --dry-run --recursive folly\n...\nscoop install versions/boost-msvc142\n```\n\nInstall locally using the suggested command\n\nCheck that local folly local build picks them up\n```\npython build/fbcode_builder/getdeps.py build --allow-system-packages --src-dir=. folly\n```\n\nRegenerate CI\n```\n# check linux and mac still ok\npython build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --free-up-disk --os-type=linux --os-type=darwin --output-dir=.github/workflows folly\n# new windows ones\npython build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --os-type=windows --output-dir=.github/workflows folly\n```\n\nFinally, let github CI run to verify that its ok when not on my machine","shortMessageHtmlLink":"use scoop for system deps on windows"}},{"before":"8aceb9bf727c42de013dd3fff8c89bd5d75ff11b","after":"f16c79b9873e435264378367582adda546d8b593","ref":"refs/heads/main","pushedAt":"2024-04-06T15:17:52.000Z","pushType":"push","commitsCount":121,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"fix parsing in UniqueInstance after supporting incomplete types\n\nSummary: The crash message may change subtly after allowing `UniqueInstance` to support incomplete types in: {D55574328}. This causes the `SingletonThreadLocal` tests to fail, noting the difference in crash message between actual and expected. The delta is just extra spaces, so it is fixable.\n\nReviewed By: Gownta\n\nDifferential Revision: D55636182\n\nfbshipit-source-id: d48dfb0bbdf730c6a276ffbe5eaf925ad5e9af6c","shortMessageHtmlLink":"fix parsing in UniqueInstance after supporting incomplete types"}},{"before":null,"after":"5264efd03ebf2430b1b62c820e8706174d108cd2","ref":"refs/heads/windows_choco","pushedAt":"2024-03-17T19:57:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"use choco for system deps on windows\n\nSummary:\nAdd system dep support for windows so that each github CI run doesn't rebuild boost\n\nWent with choco rather than vcpkg or winget as choco installs its packages in a way that are by default visible to cmake and visual studio build tools\n\nTest Plan:\n\nCheck locally what system packages would be installed\n```\npython build/fbcode_builder/getdeps.py install-system-deps --dry-run --recursive folly\n...\nchoco install -y boost-msvc-14.2\n```\n\nInstall them locally in an admin terminal\n```\nchoco install -y boost-msvc-14.2\n```\n\nCheck that local folly local build picks them up\n```\npython build/fbcode_builder/getdeps.py build --allow-system-packages --src-dir=. folly\n```\n\nRegenerate CI\n```\n# check linux and mac still ok\npython build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --free-up-disk --os-type=linux --os-type=darwin --output-dir=.github/workflows folly\n# new windows ones\npython build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --os-type=windows --output-dir=.github/workflows folly\n```\n\nFinally, let github CI run to verify that its ok when not on my machine","shortMessageHtmlLink":"use choco for system deps on windows"}},{"before":"aeeb2fa6e094fb9fba6c1947781a8189affc1e6f","after":"5264efd03ebf2430b1b62c820e8706174d108cd2","ref":"refs/heads/fix_linux_ci","pushedAt":"2024-03-17T19:54:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"use choco for system deps on windows\n\nSummary:\nAdd system dep support for windows so that each github CI run doesn't rebuild boost\n\nWent with choco rather than vcpkg or winget as choco installs its packages in a way that are by default visible to cmake and visual studio build tools\n\nTest Plan:\n\nCheck locally what system packages would be installed\n```\npython build/fbcode_builder/getdeps.py install-system-deps --dry-run --recursive folly\n...\nchoco install -y boost-msvc-14.2\n```\n\nInstall them locally in an admin terminal\n```\nchoco install -y boost-msvc-14.2\n```\n\nCheck that local folly local build picks them up\n```\npython build/fbcode_builder/getdeps.py build --allow-system-packages --src-dir=. folly\n```\n\nRegenerate CI\n```\n# check linux and mac still ok\npython build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --free-up-disk --os-type=linux --os-type=darwin --output-dir=.github/workflows folly\n# new windows ones\npython build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --os-type=windows --output-dir=.github/workflows folly\n```\n\nFinally, let github CI run to verify that its ok when not on my machine","shortMessageHtmlLink":"use choco for system deps on windows"}},{"before":"b5297454d520bafdcf1fcb23e67cf6f67575e018","after":"8aceb9bf727c42de013dd3fff8c89bd5d75ff11b","ref":"refs/heads/main","pushedAt":"2024-03-17T18:32:58.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"Define callback types for folly::ExecutionObserver\n\nSummary:\nFor folly::ExecutionObserver we want to know what type of callback are we dealing with. Currently introducing 4 different types of callbacks:\n\n1. LibeventCallbacks - Those are the ones inside EventHandler::libeventCallback\n2. LoopCallbacks -  Those are user defined callbacks, classes derived from LoopCallback and implementing `runLoopCallback` method\n3. NotificationQueueCallbacks - Anytime someones does `runInEventBaseThread` from different thread we put this on notification queue and then execute them as a batch\n4. Fiber callbacks - Not sure if we really needs this?\n\nReviewed By: ot\n\nDifferential Revision: D54395157\n\nfbshipit-source-id: fe79adf5986f9e8dc79f93fae9f39c457d9961b2","shortMessageHtmlLink":"Define callback types for folly::ExecutionObserver"}},{"before":"b9a732869a188d77910d2854ce83983f59bfc2dc","after":"b5297454d520bafdcf1fcb23e67cf6f67575e018","ref":"refs/heads/main","pushedAt":"2024-03-15T16:34:21.000Z","pushType":"push","commitsCount":56,"pusher":{"login":"ahornby","name":"Alex Hornby","path":"/ahornby","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14246801?s=80&v=4"},"commit":{"message":"cut handling for openssl v1.0.2\n\nSummary: The required minimum version of openssl is v1.1.0.\n\nReviewed By: dmm-fb\n\nDifferential Revision: D54766358\n\nfbshipit-source-id: 6e4f1917d5d0406116cf0f467919decf1b03c064","shortMessageHtmlLink":"cut handling for openssl v1.0.2"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNy0yNFQwOTo0NToyNy4wMDAwMDBazwAAAASHw2n2","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNy0yNFQwOTo0NToyNy4wMDAwMDBazwAAAASHw2n2","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wMy0xNVQxNjozNDoyMS4wMDAwMDBazwAAAAQW36uR"}},"title":"Activity · ahornby/folly"}