Skip to content

Commit 27051ef

Browse files
authored
ci: Enable github arm workflow for sglang (#3940) (#3942)
Signed-off-by: Tushar Sharma <[email protected]>
1 parent 76bbb91 commit 27051ef

File tree

1 file changed

+12
-21
lines changed

1 file changed

+12
-21
lines changed

.github/workflows/container-validation-backends.yml

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -160,17 +160,14 @@ jobs:
160160
sglang:
161161
needs: changed-files
162162
if: needs.changed-files.outputs.has_code_changes == 'true'
163-
# OPS-1140: Uncomment this for sglang arm switch to wideep
164-
# strategy:
165-
# fail-fast: false
166-
# matrix:
167-
# platform:
168-
# - { arch: amd64, runner: gpu-l40-amd64 }
169-
# - { arch: arm64, runner: cpu-arm-r8g-4xlarge }
170-
# name: sglang (${{ matrix.platform.arch }})
171-
# runs-on: ${{ matrix.platform.runner }}
172-
# OPS-1140: Remove this runs-on line, replaced with the above line
173-
runs-on: gpu-l40-amd64
163+
strategy:
164+
fail-fast: false
165+
matrix:
166+
platform:
167+
- { arch: amd64, runner: gpu-l40-amd64 }
168+
- { arch: arm64, runner: cpu-arm-r8g-4xlarge }
169+
name: sglang (${{ matrix.platform.arch }})
170+
runs-on: ${{ matrix.platform.runner }}
174171
steps:
175172
- name: Checkout repository
176173
uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0
@@ -181,9 +178,7 @@ jobs:
181178
with:
182179
framework: sglang
183180
target: runtime
184-
platform: 'linux/amd64'
185-
# OPS-1140: Replace the above line with the uncommented below line
186-
# platform: 'linux/${{ matrix.platform.arch }}'
181+
platform: 'linux/${{ matrix.platform.arch }}'
187182
ngc_ci_access_token: ${{ secrets.NGC_CI_ACCESS_TOKEN }}
188183
ci_token: ${{ secrets.CI_TOKEN }}
189184
aws_default_region: ${{ secrets.AWS_DEFAULT_REGION }}
@@ -196,9 +191,7 @@ jobs:
196191
uses: ./.github/actions/docker-tag-push
197192
with:
198193
local_image: ${{ steps.build-image.outputs.image_tag }}
199-
push_tag: ai-dynamo/dynamo:${{ github.sha }}-sglang-amd64
200-
# OPS-1140: Replace the above line with the uncommented below line
201-
# push_tag: ai-dynamo/dynamo:${{ github.sha }}-sglang-${{ matrix.platform.arch }}
194+
push_tag: ai-dynamo/dynamo:${{ github.sha }}-sglang-${{ matrix.platform.arch }}
202195
# OPS-1145: Switch aws_push to true
203196
aws_push: 'false'
204197
azure_push: 'true'
@@ -209,8 +202,7 @@ jobs:
209202
azure_acr_password: ${{ secrets.AZURE_ACR_PASSWORD }}
210203

211204
- name: Run unit tests
212-
# OPS-1140: Uncomment the below line
213-
# if: ${{ matrix.platform.arch != 'arm64' }}
205+
if: ${{ matrix.platform.arch != 'arm64' }}
214206
uses: ./.github/actions/pytest
215207
with:
216208
image_tag: ${{ steps.build-image.outputs.image_tag }}
@@ -219,8 +211,7 @@ jobs:
219211
test_type: "unit"
220212
platform_arch: ${{ matrix.platform.arch }}
221213
- name: Run e2e tests
222-
# OPS-1140: Uncomment the below line
223-
# if: ${{ matrix.platform.arch != 'arm64' }}
214+
if: ${{ matrix.platform.arch != 'arm64' }}
224215
uses: ./.github/actions/pytest
225216
with:
226217
image_tag: ${{ steps.build-image.outputs.image_tag }}

0 commit comments

Comments
 (0)