Removing backend_requirements and having separate conftest file for each backend

Signed-off-by: pvijayakrish <[email protected]>

Author: pvijayakrish

components/src/dynamo/sglang/tests/conftest.py

@@ -1,10 +1,9 @@
 # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 
-"""Conftest for dynamo backend unit tests.
-
-Handles conditional test collection to prevent import errors when backend
-frameworks are not installed in the current container.
+"""Conftest for dynamo.sglang unit tests only.
+Handles conditional test collection to prevent import errors when the sglang
+framework is not installed in the current container.
 """
 
 import importlib.util
@@ -14,62 +13,29 @@
 
 
 def pytest_ignore_collect(collection_path, config):
-    """Skip collecting backend test files if their framework isn't installed.
-
-    Checks test file naming pattern: test_<backend>_*.py
+    """Skip collecting sglang test files if sglang module isn't installed.
+    Checks test file naming pattern: test_sglang_*.py
     """
     filename = collection_path.name
-
-    # Map test file prefixes to required modules
-    backend_requirements = {
-        "test_vllm_": "vllm",
-        "test_sglang_": "sglang",
-        "test_trtllm_": "tensorrt_llm",
-    }
-
-    for prefix, required_module in backend_requirements.items():
-        if filename.startswith(prefix):
-            if importlib.util.find_spec(required_module) is None:
-                return True  # Module not available, skip this file
-
-    return None  # Not a backend test or module available
+    if filename.startswith("test_sglang_"):
+        if importlib.util.find_spec("sglang") is None:
+            return True  # sglang not available, skip this file
+    return None
 
 
 def make_cli_args_fixture(module_name: str):
-    """Create a pytest fixture for mocking CLI arguments for a backend.
-
-    The returned fixture supports two call styles:
-
-    1. Explicit:
-        mock_vllm_cli("--model", "gpt-2", "--custom-jinja-template", "path.jinja")
-
-    2. Kwargs (auto-converts underscores to hyphens):
-        mock_vllm_cli(model="gpt-2", custom_jinja_template="path.jinja")
-
-    Both produce: ["dynamo.vllm", "--model", "gpt-2", "--custom-jinja-template", "path.jinja"]
-
-    Args:
-        module_name: Module identifier for argv[0] (e.g., "dynamo.vllm")
-
-    Returns:
-        Pytest fixture that mocks sys.argv via monkeypatch
-    """
+    """Create a pytest fixture for mocking CLI arguments for sglang backend."""
 
     @pytest.fixture
     def mock_cli_args(monkeypatch):
-        """Mock sys.argv with CLI arguments (explicit or kwargs style)."""
-
         def set_args(*args, **kwargs):
             if args:
-                # Explicit style: pass argv elements directly
                 argv = [module_name, *args]
             else:
-                # Kwargs style: convert python arg to CLI arg
                 argv = [module_name]
                 for param_name, param_value in kwargs.items():
                     cli_flag = f"--{param_name.replace('_', '-')}"
                     argv.extend([cli_flag, str(param_value)])
-
             monkeypatch.setattr(sys, "argv", argv)
 
         return set_args

components/src/dynamo/trtllm/tests/conftest.py

@@ -1,10 +1,9 @@
 # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 
-"""Conftest for dynamo backend unit tests.
-
-Handles conditional test collection to prevent import errors when backend
-frameworks are not installed in the current container.
+"""Conftest for dynamo.trtllm unit tests only.
+Handles conditional test collection to prevent import errors when the tensorrt_llm
+framework is not installed in the current container.
 """
 
 import importlib.util
@@ -14,62 +13,29 @@
 
 
 def pytest_ignore_collect(collection_path, config):
-    """Skip collecting backend test files if their framework isn't installed.
-
-    Checks test file naming pattern: test_<backend>_*.py
+    """Skip collecting trtllm test files if tensorrt_llm module isn't installed.
+    Checks test file naming pattern: test_trtllm_*.py
     """
     filename = collection_path.name
-
-    # Map test file prefixes to required modules
-    backend_requirements = {
-        "test_vllm_": "vllm",
-        "test_sglang_": "sglang",
-        "test_trtllm_": "tensorrt_llm",
-    }
-
-    for prefix, required_module in backend_requirements.items():
-        if filename.startswith(prefix):
-            if importlib.util.find_spec(required_module) is None:
-                return True  # Module not available, skip this file
-
-    return None  # Not a backend test or module available
+    if filename.startswith("test_trtllm_"):
+        if importlib.util.find_spec("tensorrt_llm") is None:
+            return True  # tensorrt_llm not available, skip this file
+    return None
 
 
 def make_cli_args_fixture(module_name: str):
-    """Create a pytest fixture for mocking CLI arguments for a backend.
-
-    The returned fixture supports two call styles:
-
-    1. Explicit:
-        mock_vllm_cli("--model", "gpt-2", "--custom-jinja-template", "path.jinja")
-
-    2. Kwargs (auto-converts underscores to hyphens):
-        mock_vllm_cli(model="gpt-2", custom_jinja_template="path.jinja")
-
-    Both produce: ["dynamo.vllm", "--model", "gpt-2", "--custom-jinja-template", "path.jinja"]
-
-    Args:
-        module_name: Module identifier for argv[0] (e.g., "dynamo.vllm")
-
-    Returns:
-        Pytest fixture that mocks sys.argv via monkeypatch
-    """
+    """Create a pytest fixture for mocking CLI arguments for trtllm backend."""
 
     @pytest.fixture
     def mock_cli_args(monkeypatch):
-        """Mock sys.argv with CLI arguments (explicit or kwargs style)."""
-
         def set_args(*args, **kwargs):
             if args:
-                # Explicit style: pass argv elements directly
                 argv = [module_name, *args]
             else:
-                # Kwargs style: convert python arg to CLI arg
                 argv = [module_name]
                 for param_name, param_value in kwargs.items():
                     cli_flag = f"--{param_name.replace('_', '-')}"
                     argv.extend([cli_flag, str(param_value)])
-
             monkeypatch.setattr(sys, "argv", argv)
 
         return set_args

components/src/dynamo/vllm/tests/conftest.py

@@ -1,10 +1,9 @@
 # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 
-"""Conftest for dynamo backend unit tests.
-
-Handles conditional test collection to prevent import errors when backend
-frameworks are not installed in the current container.
+"""Conftest for dynamo.vllm unit tests only.
+Handles conditional test collection to prevent import errors when the vllm
+framework is not installed in the current container.
 """
 
 import importlib.util
@@ -14,62 +13,29 @@
 
 
 def pytest_ignore_collect(collection_path, config):
-    """Skip collecting backend test files if their framework isn't installed.
-
-    Checks test file naming pattern: test_<backend>_*.py
+    """Skip collecting vllm test files if vllm module isn't installed.
+    Checks test file naming pattern: test_vllm_*.py
     """
     filename = collection_path.name
-
-    # Map test file prefixes to required modules
-    backend_requirements = {
-        "test_vllm_": "vllm",
-        "test_sglang_": "sglang",
-        "test_trtllm_": "tensorrt_llm",
-    }
-
-    for prefix, required_module in backend_requirements.items():
-        if filename.startswith(prefix):
-            if importlib.util.find_spec(required_module) is None:
-                return True  # Module not available, skip this file
-
-    return None  # Not a backend test or module available
+    if filename.startswith("test_vllm_"):
+        if importlib.util.find_spec("vllm") is None:
+            return True  # vllm not available, skip this file
+    return None
 
 
 def make_cli_args_fixture(module_name: str):
-    """Create a pytest fixture for mocking CLI arguments for a backend.
-
-    The returned fixture supports two call styles:
-
-    1. Explicit:
-        mock_vllm_cli("--model", "gpt-2", "--custom-jinja-template", "path.jinja")
-
-    2. Kwargs (auto-converts underscores to hyphens):
-        mock_vllm_cli(model="gpt-2", custom_jinja_template="path.jinja")
-
-    Both produce: ["dynamo.vllm", "--model", "gpt-2", "--custom-jinja-template", "path.jinja"]
-
-    Args:
-        module_name: Module identifier for argv[0] (e.g., "dynamo.vllm")
-
-    Returns:
-        Pytest fixture that mocks sys.argv via monkeypatch
-    """
+    """Create a pytest fixture for mocking CLI arguments for vllm backend."""
 
     @pytest.fixture
     def mock_cli_args(monkeypatch):
-        """Mock sys.argv with CLI arguments (explicit or kwargs style)."""
-
         def set_args(*args, **kwargs):
             if args:
-                # Explicit style: pass argv elements directly
                 argv = [module_name, *args]
             else:
-                # Kwargs style: convert python arg to CLI arg
                 argv = [module_name]
                 for param_name, param_value in kwargs.items():
                     cli_flag = f"--{param_name.replace('_', '-')}"
                     argv.extend([cli_flag, str(param_value)])
-
             monkeypatch.setattr(sys, "argv", argv)
 
         return set_args