chore(tests): add Platform Module Specification IDs to related tests

Author: muhabalwan-aginx

specifications/SPEC-UTILS-SERVICE.md

@@ -2,7 +2,7 @@
 itemId: SPEC-UTILS-SERVICE
 itemTitle: Utils Module Specification
 itemType: Software Item Spec
-itemFulfills:
+itemFulfills: SPEC-APPLICATION-SERVICE,  SPEC-BUCKET-SERVICE, SPEC-DATASET-SERVICE, SPEC-NOTEBOOK-SERVICE, SPEC-QUPATH-SERVICE, SPEC-SYSTEM-SERVICE
 itemIsRelatedTo: SPEC-APPLICATION-SERVICE, SPEC-GUI-SERVICE, SPEC-BUCKET-SERVICE, SPEC-DATASET-SERVICE, SPEC-NOTEBOOK-SERVICE, SPEC-PLATFORM-SERVICE, SPEC-QUPATH-SERVICE, SPEC-SYSTEM-SERVICE, SPEC-WSI-SERVICE
 Module: Utils
 Layer: Infrastructure Service

tests/aignostics/application/cli_test.py

@@ -17,39 +17,44 @@
 MESSAGE_RUN_NOT_FOUND = "Warning: Run with ID '4711' not found"
 
 
-def test_cli_application_list(runner: CliRunner) -> None:
+def test_cli_application_list(runner: CliRunner, record_property) -> None:
     """Check application list command runs successfully."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     result = runner.invoke(cli, ["application", "list"])
     assert result.exit_code == 0
     assert HETA_APPLICATION_ID in normalize_output(result.output)
     assert TEST_APPLICATION_ID in normalize_output(result.output)
 
 
-def test_cli_application_list_verbose(runner: CliRunner) -> None:
+def test_cli_application_list_verbose(runner: CliRunner, record_property) -> None:
     """Check application list command runs successfully."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     result = runner.invoke(cli, ["application", "list", "--verbose"])
     assert result.exit_code == 0
     assert HETA_APPLICATION_ID in normalize_output(result.output)
     assert "Artifacts: 1 input(s), 6 output(s)" in normalize_output(result.output)
     assert TEST_APPLICATION_ID in normalize_output(result.output)
 
 
-def test_cli_application_describe(runner: CliRunner) -> None:
+def test_cli_application_describe(runner: CliRunner, record_property) -> None:
     """Check application describe command runs successfully."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     result = runner.invoke(cli, ["application", "describe", HETA_APPLICATION_ID])
     assert result.exit_code == 0
     assert "tissue_qc:geojson_polygons" in normalize_output(result.output)
 
 
-def test_cli_application_describe_not_found(runner: CliRunner) -> None:
+def test_cli_application_describe_not_found(runner: CliRunner, record_property) -> None:
     """Check application describe command fails as expected on unknown application."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     result = runner.invoke(cli, ["application", "describe", "unknown"])
     assert result.exit_code == 2
     assert "Application with ID 'unknown' not found." in normalize_output(result.output)
 
 
-def test_cli_application_dump_schemata(runner: CliRunner, tmp_path: Path) -> None:
+def test_cli_application_dump_schemata(runner: CliRunner, tmp_path: Path, record_property) -> None:
     """Check application dump schemata works as expected."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     result = runner.invoke(
         cli, ["application", "dump-schemata", HETA_APPLICATION_ID, "--destination", str(tmp_path), "--zip"]
     )
@@ -102,8 +107,9 @@ def test_cli_application_run_prepare_upload_submit_fail_on_mpp(
     assert "8.065226874391001 is greater than" in normalize_output(result.stdout)
 
 
-def test_cli_application_run_upload_fails_on_missing_source(runner: CliRunner, tmp_path: Path) -> None:
+def test_cli_application_run_upload_fails_on_missing_source(runner: CliRunner, tmp_path: Path, record_property) -> None:
     """Check application run prepare command and upload works and submit fails on mpp not supported."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     metadata_csv = tmp_path / "metadata.csv"
     metadata_csv.write_text(
         "reference;checksum_base64_crc32c;resolution_mpp;width_px;height_px;staining_method;tissue;disease;"
@@ -117,8 +123,9 @@ def test_cli_application_run_upload_fails_on_missing_source(runner: CliRunner, t
     assert "Warning: Source file 'missing.file' (row 0) does not exist" in normalize_output(result.stdout)
 
 
-def test_cli_run_submit_fails_on_application_not_found(runner: CliRunner, tmp_path: Path) -> None:
+def test_cli_run_submit_fails_on_application_not_found(runner: CliRunner, tmp_path: Path, record_property) -> None:
     """Check run submit command fails as expected."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     csv_content = "reference;checksum_base64_crc32c;resolution_mpp;width_px;height_px;staining_method;tissue;disease;"
     csv_content += "platform_bucket_url\n"
     csv_content += ";5onqtA==;0.26268186053789266;7447;7196;H&E;LUNG;LUNG_CANCER;gs://bucket/test"
@@ -131,8 +138,9 @@ def test_cli_run_submit_fails_on_application_not_found(runner: CliRunner, tmp_pa
     assert "Error: Failed to create run for application version" in normalize_output(result.stdout)
 
 
-def test_cli_run_submit_fails_on_unsupported_cloud(runner: CliRunner, tmp_path: Path) -> None:
+def test_cli_run_submit_fails_on_unsupported_cloud(runner: CliRunner, tmp_path: Path, record_property) -> None:
     """Check run submit command fails as expected."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     csv_content = "reference;checksum_base64_crc32c;resolution_mpp;width_px;height_px;staining_method;tissue;disease;"
     csv_content += "platform_bucket_url\n"
     csv_content += ";5onqtA==;0.26268186053789266;7447;7196;H&E;LUNG;LUNG_CANCER;aws://bucket/test"
@@ -145,8 +153,9 @@ def test_cli_run_submit_fails_on_unsupported_cloud(runner: CliRunner, tmp_path:
     assert "Invalid platform bucket URL: 'aws://bucket/test'" in normalize_output(result.stdout)
 
 
-def test_cli_run_submit_fails_on_missing_url(runner: CliRunner, tmp_path: Path) -> None:
+def test_cli_run_submit_fails_on_missing_url(runner: CliRunner, tmp_path: Path, record_property) -> None:
     """Check run submit command fails as expected."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     csv_content = "reference;checksum_base64_crc32c;resolution_mpp;width_px;height_px;staining_method;tissue;disease;"
     csv_content += "platform_bucket_url\n"
     csv_content += ";5onqtA==;0.26268186053789266;7447;7196;H&E;LUNG;LUNG_CANCER;"
@@ -232,8 +241,9 @@ def test_cli_run_submit_and_describe_and_cancel_and_download(
         assert f"Failed to create destination directory '/4711/{run_id}'" in normalize_output(download_result.stdout)
 
 
-def test_cli_run_list_limit_10(runner: CliRunner) -> None:
+def test_cli_run_list_limit_10(runner: CliRunner, record_property) -> None:
     """Check run list command runs successfully."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     result = runner.invoke(cli, ["application", "run", "list", "--limit", "10"])
     assert result.exit_code == 0
     output = normalize_output(result.stdout)
@@ -245,8 +255,9 @@ def test_cli_run_list_limit_10(runner: CliRunner) -> None:
     assert displayed_count <= 10, f"Expected listed count to be <= 10, but got {displayed_count}"
 
 
-def test_cli_run_list_verbose_limit_1(runner: CliRunner) -> None:
+def test_cli_run_list_verbose_limit_1(runner: CliRunner, record_property) -> None:
     """Check run list command runs successfully."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     result = runner.invoke(cli, ["application", "run", "list", "--verbose", "--limit", "1"])
     assert result.exit_code == 0
     output = normalize_output(result.stdout)
@@ -258,52 +269,59 @@ def test_cli_run_list_verbose_limit_1(runner: CliRunner) -> None:
     assert displayed_count == 1, f"Expected listed count to be == 1, but got {displayed_count}"
 
 
-def test_cli_run_describe_invalid_uuid(runner: CliRunner) -> None:
+def test_cli_run_describe_invalid_uuid(runner: CliRunner, record_property) -> None:
     """Check run describe command fails as expected on run not found."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     result = runner.invoke(cli, ["application", "run", "describe", "4711"])
     assert result.exit_code == 1
     assert "Error: Failed to retrieve run details for ID '4711'" in normalize_output(result.stdout)
 
 
-def test_cli_run_describe_not_found(runner: CliRunner) -> None:
+def test_cli_run_describe_not_found(runner: CliRunner, record_property) -> None:
     """Check run describe command fails as expected on run not found."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     result = runner.invoke(cli, ["application", "run", "describe", "00000000000000000000000000000000"])
     assert result.exit_code == 2
     assert "Warning: Run with ID '00000000000000000000000000000000' not found." in normalize_output(result.stdout)
 
 
-def test_cli_run_cancel_invalid_run_id(runner: CliRunner) -> None:
+def test_cli_run_cancel_invalid_run_id(runner: CliRunner, record_property) -> None:
     """Check run cancel command fails as expected on run not found."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     result = runner.invoke(cli, ["application", "run", "cancel", "4711"])
     assert result.exit_code == 1
     assert "Failed to cancel run with ID '4711'" in normalize_output(result.stdout)
 
 
-def test_cli_run_cancel_not_found(runner: CliRunner) -> None:
+def test_cli_run_cancel_not_found(runner: CliRunner, record_property) -> None:
     """Check run cancel command fails as expected on run not found."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     result = runner.invoke(cli, ["application", "run", "cancel", "00000000000000000000000000000000"])
     assert result.exit_code == 2
     assert "Warning: Run with ID '00000000000000000000000000000000' not found." in normalize_output(result.stdout)
 
 
-def test_cli_run_result_download_invalid_uuid(runner: CliRunner, tmp_path: Path) -> None:
+def test_cli_run_result_download_invalid_uuid(runner: CliRunner, tmp_path: Path, record_property) -> None:
     """Check run result download command fails on invalid uui."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     result = runner.invoke(cli, ["application", "run", "result", "download", "4711", str(tmp_path)])
     assert result.exit_code == 2
     assert "Run ID '4711' invalid" in normalize_output(result.stdout)
 
 
-def test_cli_run_result_download_uuid_not_found(runner: CliRunner, tmp_path: Path) -> None:
+def test_cli_run_result_download_uuid_not_found(runner: CliRunner, tmp_path: Path, record_property) -> None:
     """Check run result download fails on ID not found."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     result = runner.invoke(
         cli, ["application", "run", "result", "download", "00000000000000000000000000000000", str(tmp_path)]
     )
     assert "Run with ID '00000000000000000000000000000000' not found." in result.output.replace("\n", "")
     assert result.exit_code == 2
 
 
-def test_cli_run_result_delete(runner: CliRunner) -> None:
+def test_cli_run_result_delete(runner: CliRunner, record_property) -> None:
     """Check run result delete command runs successfully."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     result = runner.invoke(cli, ["application", "run", "result", "delete"])
     assert result.exit_code == 1
     assert MESSAGE_NOT_YET_IMPLEMENTED in normalize_output(result.stdout)

tests/aignostics/application/gui_test.py

@@ -25,8 +25,9 @@
 
 
 @pytest.mark.sequential
-async def test_gui_index(user: User) -> None:
+async def test_gui_index(user: User, record_property) -> None:
     """Test that the user sees the index page, and sees the intro."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     # hello world
     gui_register_pages()
     await user.open("/")
@@ -50,9 +51,10 @@ async def test_gui_index(user: User) -> None:
     ],
 )
 async def test_gui_home_to_application(
-    user: User, application_id: str, application_name: str, expected_text: str, silent_logging: None
+    user: User, application_id: str, application_name: str, expected_text: str, silent_logging: None, record_property
 ) -> None:
     """Test that the user sees the specific application page with expected content."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     gui_register_pages()
     await user.open("/")
     await user.should_see(application_name, retries=100)
@@ -61,8 +63,9 @@ async def test_gui_home_to_application(
 
 
 @pytest.mark.flaky(retries=1, delay=5, only_on=[AssertionError])
-async def test_gui_cli_to_run_cancel(user: User, runner: CliRunner, silent_logging) -> None:
+async def test_gui_cli_to_run_cancel(user: User, runner: CliRunner, silent_logging: None, record_property) -> None:
     """Test that the user sees the index page, and sees the intro."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     with tempfile.TemporaryDirectory() as tmpdir:
         gui_register_pages()
 
@@ -208,8 +211,11 @@ async def test_gui_download_dataset_via_application_to_run_cancel(  # noqa: PLR0
 
 
 @pytest.mark.sequential
-async def test_gui_run_download(user: User, runner: CliRunner, tmp_path: Path, silent_logging: None) -> None:
+async def test_gui_run_download(
+    user: User, runner: CliRunner, tmp_path: Path, silent_logging: None, record_property
+) -> None:
     """Test that the user can download a run result via the GUI."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     with patch(
         "aignostics.application._gui._page_application_run_describe.get_user_data_directory", return_value=tmp_path
     ):

tests/aignostics/application/service_test.py

@@ -41,8 +41,9 @@ def test_application_version_valid_semver_formats(runner: CliRunner) -> None:
             pytest.skip(f"Application '{version_id.split(':')[0]}' not found, skipping test for this version format.")
 
 
-def test_application_version_invalid_semver_formats(runner: CliRunner) -> None:
+def test_application_version_invalid_semver_formats(runner: CliRunner, record_property) -> None:
     """Test that invalid semver formats are rejected with ValueError."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     from aignostics.application import Service as ApplicationService
 
     service = ApplicationService()
@@ -72,8 +73,9 @@ def test_application_version_invalid_semver_formats(runner: CliRunner) -> None:
             service.application_version(version_id)
 
 
-def test_application_version_use_latest_fallback(runner: CliRunner) -> None:
+def test_application_version_use_latest_fallback(runner: CliRunner, record_property) -> None:
     """Test that use_latest_if_no_version_given works correctly."""
+    record_property("tested-item-id", "SPEC-APPLICATION-SERVICE")
     service = ApplicationService()
 
     try: