aiodns can probably be enabled on windows, now that it ships with c-ares already built #8121
Closed
1 task done
Labels
Comments
|
You can still use it, the dependency helper ( |
|
Should be an easy fix then, especially if it's strongly recommended for performance reason. |
|
You could make a PR to see how our CI likes it. |
|
It installs, but loads of the tests fail and then on one of the tests it appears to hang. @bdraco thinks it may work on the selector event loop (which is not the default), so if someone wants to add some conditional checks around that to support it, we can look at including it by default. But, currently, it looks like installing it will just break everything for most users. |
bdraco
added a commit
that referenced
this issue
May 2, 2025
As of aiodns 3.3.0 SelectorEventLoop is no longer required when using pycares 4.7.0 or later closes #8121
5 tasks
5 tasks
bdraco
added a commit
that referenced
this issue
May 3, 2025
…aiodns from being installed on Windows (#10825) Co-authored-by: J. Nick Koston <[email protected]> closes #8121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
The
aiodnslibrary from the[speedup]bundle is currently disabled on Windows per this line .However,
aiodnscurrently ships withpycares, which bundles a binary ofc-aresby default. I was just now able to install it on Win10 with pip.Describe the solution you'd like
It seems there's no need to exclude Windows from the aiodns speedup. Looks like changing https://github.com/aio-libs/aiohttp/blob/master/setup.cfg#L64 would be sufficient, but I'm by no means experienced, so I'd rather not mess with the repo myself.
Describe alternatives you've considered
There seems to be some requests to get rid of aiodns entirely in favour of pydns, but maybe till then we can use it like this?
Related component
Client
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: