Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update svgo to v3.x.x #118

Open
GamerBene19 opened this issue Jan 24, 2023 · 9 comments
Open

Update svgo to v3.x.x #118

GamerBene19 opened this issue Jan 24, 2023 · 9 comments

Comments

@GamerBene19
Copy link

GamerBene19 commented Jan 24, 2023

Currently when this package is installed you get a warning sth like this:

warning babel-plugin-inline-react-svg > svgo > [email protected]: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility

The issue in svgo has been solved (svg/svgo#1689), and the fix is included in v3.0.0.

I don't know what breaking-changes v3 causes and how much work is needed here, but it would be nice if svgo could be updated to version >=3.0.0 to get rid of that warning (and make use of new features).

@ljharb
Copy link
Collaborator

ljharb commented Jan 24, 2023

A deprecation warning on a transitive dep is just something you should ignore, always ¯\_(ツ)_/¯

That said, the breaking change of requiring node 14 basically means we likely can't ever upgrade to it.

@akirafujiu
Copy link

Node.js v14 gets retired per https://github.com/nodejs/release#release-schedule, I think you can upgrade it safely..

@ljharb
Copy link
Collaborator

ljharb commented Jul 26, 2023

Nope, platform support has zero bearing on what platforms a package should support.

@sakgoyal
Copy link

sakgoyal commented Sep 14, 2023

if a user wants support for older node versions, then just use an older version of this. you should not be required to support deprecated features.

@ljharb
Copy link
Collaborator

ljharb commented Sep 14, 2023

Nobody's required to. However, this package does.

@sakgoyal
Copy link

but why? why does this package hold back on old requirements?

@ljharb
Copy link
Collaborator

ljharb commented Jan 19, 2024

Currently, users get an annoying warning, but everyone can use the package.

If we dropped support for older environments, then the users who are in the most need - the ones stuck in older environments - would be completely unable to use the package. That's not a worthy or a sensible or compassionate tradeoff.

@sakgoyal
Copy link

who said they have to update the package? they can just use this current version without updating right?

@ljharb
Copy link
Collaborator

ljharb commented Jan 19, 2024

Then they're stuck on an older major, not getting security and bug fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants