Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting the existing symbols could be easier #328

Open
mathieudutour opened this issue May 14, 2018 · 2 comments
Open

Getting the existing symbols could be easier #328

mathieudutour opened this issue May 14, 2018 · 2 comments

Comments

@mathieudutour
Copy link
Collaborator

Right now we iterate through all the pages and then all the layers to get the symbol masters.

There is a convenient method on MSDocumentData called allSymbols and we should just use it.

@mathieudutour
Copy link
Collaborator Author

mathieudutour commented Jun 1, 2018

It's actually not that simple: injectSymbols reset the Symbols page and render all the symbols that we found. So if we use allSymbols, it will bring the symbols from other pages as well.

Probably need to tackle #316 at the same time

@nampdn
Copy link

nampdn commented Jul 27, 2018

It would be great if we could retrieve all of the available symbols into an array. Currently in v2 I couldn't find a way to achieve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants