fix: Fix lint and raise error when builder_project not found

- Fix line length issue in docstring (E501)
- Changed get_definition_id_for_connector_builder_project to raise
  AirbyteError instead of returning None when definition not found
- Simplified caller code in get_custom_source_definition to remove
  None check since API function now raises directly

Fixes lint error and addresses feedback from @aaronsteers

Co-Authored-By: AJ Steers <[email protected]>

Author: devin-ai-integration[bot]

airbyte/_util/api_util.py

@@ -1427,7 +1427,7 @@ def get_definition_id_for_connector_builder_project(
     api_root: str,
     client_id: SecretString,
     client_secret: SecretString,
-) -> str | None:
+) -> str:
     """Get the source definition ID for a connector builder project.
 
     Uses the Config API endpoint:
@@ -1443,7 +1443,10 @@ def get_definition_id_for_connector_builder_project(
         client_secret: OAuth client secret
 
     Returns:
-        The source definition ID if found, None otherwise (can be null in API response)
+        The source definition ID
+
+    Raises:
+        AirbyteError: If no definition is found for the given builder project ID
     """
     json_result = _make_config_api_request(
         path="/connector_builder_projects/get_with_manifest",
@@ -1455,4 +1458,13 @@ def get_definition_id_for_connector_builder_project(
         client_id=client_id,
         client_secret=client_secret,
     )
-    return json_result.get("sourceDefinitionId")
+    definition_id = json_result.get("sourceDefinitionId")
+    if definition_id is None:
+        raise AirbyteError(
+            message="No source definition found for the given connector builder project",
+            context={
+                "workspace_id": workspace_id,
+                "builder_project_id": builder_project_id,
+            },
+        )
+    return definition_id

airbyte/cloud/workspaces.py

@@ -591,10 +591,11 @@ def get_custom_source_definition(
         """Get a specific custom source definition by ID or builder project ID.
 
         Args:
-            definition_id: The definition ID. Mutually exclusive with `connector_builder_project_id`.
+            definition_id: The definition ID. Mutually exclusive with
+                `connector_builder_project_id`.
             definition_type: Connector type ("yaml" or "docker"). Required.
-            connector_builder_project_id: The connector builder project ID. Mutually exclusive with
-                `definition_id`.
+            connector_builder_project_id: The connector builder project ID.
+                Mutually exclusive with `definition_id`
 
         Returns:
             CustomCloudSourceDefinition object
@@ -643,18 +644,6 @@ def get_custom_source_definition(
                     client_secret=self.client_secret,
                 )
 
-                if definition_id is None:
-                    raise exc.AirbyteError(
-                        message=(
-                            "No custom source definition found with the given "
-                            "connector_builder_project_id"
-                        ),
-                        context={
-                            "workspace_id": self.workspace_id,
-                            "connector_builder_project_id": connector_builder_project_id,
-                        },
-                    )
-
                 result = api_util.get_custom_yaml_source_definition(
                     workspace_id=self.workspace_id,
                     definition_id=definition_id,