Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure database context is set before schema creation in Snowflake #589

Closed
wants to merge 11 commits into from
Closed

fix: ensure database context is set before schema creation in Snowflake #589

wants to merge 11 commits into from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Fixes Snowflake schema creation by ensuring database context is properly set.

This PR:

  1. Overrides _ensure_schema_exists in SnowflakeSqlProcessor to properly set database context
  2. Uses fully qualified schema names in CREATE SCHEMA statements
  3. Maintains existing error handling for schema existence

Link to Devin run: https://app.devin.ai/sessions/be3168a4b7974151b7cf9f082e47e893

@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

Original prompt:

@Devin - PyAirbyte CI tests are failing in new PRs. Can you investigate. Looks like Snowflake account is missing a DB or has its default DB changed.

@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

devin-ai-integration bot and others added 9 commits January 28, 2025 04:29
@devin-ai-integration @aaronsteers
fix: add DEBUG_MODE constant and fix docstring whitespace
d9a2068 
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
@devin-ai-integration @aaronsteers
style: fix import block formatting
7ec3724 
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
@devin-ai-integration @aaronsteers
ci: update snowflake info to print account and username
ed1766d 
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
@devin-ai-integration @aaronsteers
ci: add snowflake credentials to test environment
24903b9 
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
@devin-ai-integration @aaronsteers
ci: update snowflake info to print account, username, and default db
041f278 
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
@devin-ai-integration @aaronsteers
ci: update snowflake info to print config from GSM secrets
325ebc7 
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
@devin-ai-integration @aaronsteers
feat: add Snowflake environment info printing via SQL commands
300025f 
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
@devin-ai-integration @aaronsteers
style: fix linting issues in Snowflake SQL command
076a520 
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
@devin-ai-integration @aaronsteers
fix: update snowflake debug info to use direct SQL commands
0ce07f5 
Co-Authored-By: Aaron <AJ> Steers <[email protected]>
@aaronsteers
Copy link
Contributor

Replaced by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronsteers aaronsteers Awaiting requested review from aaronsteers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aaronsteers