fix: Poetry builds and snowflake tests #595
Conversation
📝 WalkthroughWalkthroughThe pull request focuses on updating the Changes
Possibly related PRs
What do you think about these updates? Do you want to dive deeper into any specific area? 😊 ✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
tests/integration_tests/cloud/test_cloud_sql_reads.py (4)
36-43: Love the addition of connection URLs! 🎉Great job documenting the connection IDs with their cloud URLs! This will help developers quickly check connection status. Would it be helpful to add a brief comment about what kind of test data we expect from each connection, wdyt?
85-89: Could we clarify what causes the column count variation? 🤔Nice flexibility allowing for both 20 and 21 columns! The comment mentions it depends on "when it was created" - would it be helpful to document what specifically changed in the schema to cause this variation? This could help future maintainers understand if they see different column counts.
100-106: Consider reducing URL duplication? 💭The connection URLs are duplicated from the first test. What do you think about defining these as constants at the module level? Something like:
SNOWFLAKE_CONN_ID = "c7b4d838-a612-495a-9d91-a14e477add51" SNOWFLAKE_CONN_URL = "https://cloud.airbyte.com/workspaces/a0cc325a-d358-4df4-bdd4-c09d753b6afb/connections/c7b4d838-a612-495a-9d91-a14e477add51/status"This would make updates easier and reduce the chance of URLs getting out of sync. Wdyt?
198-202: Consider extracting DataFrame validation to a helper? 🛠️These shape assertions are identical to the ones in
test_read_from_deployed_connection. What do you think about extracting them into a helper function? Something like:def assert_valid_users_dataframe(df: pd.DataFrame) -> None: """Validate the shape and content of the users DataFrame.""" assert df.shape[0] == 100 assert df.shape[1] in {20, 21} # Column count diff depending on when it was createdThis would make the tests more DRY and easier to maintain. Thoughts?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/integration_tests/cloud/test_cloud_sql_reads.py(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Pytest (All, Python 3.11, Windows)
- GitHub Check: Pytest (All, Python 3.11, Ubuntu)
- GitHub Check: Pytest (No Creds)
- GitHub Check: Pytest (All, Python 3.10, Windows)
- GitHub Check: Pytest (All, Python 3.10, Ubuntu)
- GitHub Check: Pytest (Fast)
Summary by CodeRabbit
poetry-core