[source volcano] Allow meta field to be queried in SelectQuerySpec #52677
+16
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As we add trigger based CDC for Sap Hana, existing CDK does not support this use case.
Here is the conflict in CDK:
If we define trigger table schema using meta field type, we cannot query the table. If we define trigger table schema using field type, we cannot define the cursor at discovery phase.
How
So we either change SelectQuerySpec to support meta field type or we change MetaFieldDecorator to support field type as cursor. I have put both changes in this PR.
I would prefer to change SelectQuerySpec but open to other thoughts
Review guide
Please suggest which file to change to support trigger table schema
User Impact
No
Can this PR be safely reverted and rolled back?