Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[source volcano] Allow meta field to be queried in SelectQuerySpec #52677

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

burakku
Copy link
Contributor

@burakku burakku commented Jan 31, 2025

What

As we add trigger based CDC for Sap Hana, existing CDK does not support this use case.
Here is the conflict in CDK:

  • we need to query trigger table to get changes, trigger table schema is in either field type or meta field type.
  • we need to define cursor at discovery phase for stream. CDC cursor currently is defined as meta field type.

If we define trigger table schema using meta field type, we cannot query the table. If we define trigger table schema using field type, we cannot define the cursor at discovery phase.

How

So we either change SelectQuerySpec to support meta field type or we change MetaFieldDecorator to support field type as cursor. I have put both changes in this PR.

I would prefer to change SelectQuerySpec but open to other thoughts

Review guide

Please suggest which file to change to support trigger table schema

User Impact

No

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@burakku burakku requested a review from a team as a code owner January 31, 2025 07:00
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 7:00am

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants