Potential dependency conflicts between airflow-docker-compose and docker

[NeolithEra]

Hi, as shown in the following full dependency graph of airflow-docker-compose, airflow-docker-compose requires docker (the latest version)， while the installed version of docker-compose(1.25.5) requires docker>=3.7.0,<5.

According to Pip's “first found wins” installation strategy, docker 4.2.0 is the actually installed version.

Although the first found package version docker 4.2.0 just satisfies the later dependency constraint （docker>=3.7.0,<5), it will lead to a build failure once developers release a newer version of docker.

Dependency tree--------

airflow-docker-compose - 0.1.9
| +- click(install version:7.1.1 version range:*)
| +- docker(install version:4.2.0 version range:*)
| | +- requests (install version:2.23.0 version range:>=2.14.2)
| | | +- certifi(install version:2020.4.5.1 version range:>=2017.4.17)
| | | +- chardet(install version:3.0.4 version range:>=3.0.2,<4)
| | | +- idna(install version:2.9 version range:>=2.5,<3)
| | | +- urllib3(install version:1.25.9 version range:>=1.21.1,<1.26)
| | +- six (install version:1.14.0 version range:>=1.4.0)
| | +- websocket-client (install version:0.57.0 version range:>=0.32.0)
| | | +- six(install version:1.15.0 version range:*)
| +- docker-compose(install version:1.25.5 version range:*)
| | +- cached-property (install version:1.5.1 version range:>=1.2.0,<2)
| | +- docker(install version:4.2.0 version range:>=3.7.0,<5)
| | | +- requests (install version:2.23.0 version range:>=2.14.2)
| | | | +- certifi(install version:2020.4.5.1 version range:>=2017.4.17)
| | | | +- chardet(install version:3.0.4 version range:>=3.0.2,<4)
| | | | +- idna(install version:2.9 version range:>=2.5,<3)
| | | | +- urllib3(install version:1.25.9 version range:>=1.21.1,<1.26)
| | | +- six (install version:1.14.0 version range:>=1.4.0)
| | | +- websocket-client (install version:0.57.0 version range:>=0.32.0)
| | | | +- six(install version:1.15.0 version range:*)
| | +- dockerpty(install version:0.4.1 version range:<1,>=0.4.1)
| | | +- six(install version:1.15.0 version range:>=1.3.0)
| | +- docopt (install version:0.6.2 version range:>=0.6.1,<1)
| | +- jsonschema(install version:3.2.0 version range:<4,>=2.5.1)
| | +- PyYAML (install version:5.3.1 version range:>=3.10,<6)
| | +- requests (install version:2.23.0 version range:>=2.20.0,<3)
| | | +- certifi(install version:2020.4.5.1 version range:>=2017.4.17)
| | | +- chardet(install version:3.0.4 version range:>=3.0.2,<4)
| | | +- idna(install version:2.9 version range:>=2.5,<3)
| | | +- urllib3(install version:1.25.9 version range:>=1.21.1,<1.26)
| | +- requests(install version:2.23.0 version range:<3,>=2.20.0)
| | | +- certifi(install version:2020.4.5.1 version range:>=2017.4.17)
| | | +- chardet(install version:3.0.4 version range:>=3.0.2,<4)
| | | +- idna(install version:2.9 version range:>=2.5,<3)
| | | +- urllib3(install version:1.25.9 version range:>=1.21.1,<1.26)
| | +- six(install version:1.15.0 version range:>=1.3.0,<2)
| | +- texttable (install version:1.6.2 version range:>=0.9.0,<2)
| | +- texttable(install version:1.6.2 version range:<2,>=0.9.0)
| | +- websocket-client (install version:0.57.0 version range:>=0.32.0,<1)
| | | +- six(install version:1.15.0 version range:*)
| +- python-dotenv(install version:0.12.0 version range:*)
| | +- typing(install version:3.7.4.1 version range:*)
| +- toml(install version:0.10.0 version range:*)

Thanks for your attention.
Best,
Neolith

[NeolithEra]

Solution

1. Loosen the version range of docker to be <=4.2.0.
2. Remove your direct dependency docker, and use the docker transitively introduced by docker-compose.

@DanCardin Which solution do you prefer, 1 or 2?
Please let me know your choice. May I pull a request to solve this issue?

[DanCardin]

Maybe I'm misunderstanding what you're saying, but if you look at the pyproject.toml both docker and docker-compose's versions are left unspecified as * (since we're not using any features in particular from either which would be version dependent as far as i know).

So I wouldn't expect a build failure on newer versions