Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ace-builds tar file releases contain same filenames with differing capitalization #5755

Open
hartman opened this issue Feb 25, 2025 · 1 comment
Labels

Comments

@hartman
Copy link
Contributor

hartman commented Feb 25, 2025

Describe the bug

I noticed that at least the releases:

contain a file with the same name but with differing capitalization:

tar -tf v1.37.1 | grep hx
ace-builds-1.37.1/demo/kitchen-sink/docs/Haxe.hx
ace-builds-1.37.1/demo/kitchen-sink/docs/haxe.hx

Expected Behavior

The tar file should not contain two files with the same name and differing capitalization

Current Behavior

When you attempt to extract this file on file systems that are case preserving and case insensitive (for instance macOS), you get undefined behavior when extracting these tar files.

Generally, the later file in the manifest will override the earlier file, OR an error is thrown.

For instance, when extracting with PHPs extractTo() without allowing overwriting of files, you will have:

Error: Extraction from phar ".foreign/tmp/ace.tar" failed: Cannot extract "ace-builds-1.37.1/demo/kitchen-sink/docs/haxe.hx" to ".foreign/tmp/ace/ace-builds-1.37.1/demo/kitchen-sink/docs/haxe.hx", path already exists

but when using command line tar -xzvf, it will silenty overwrite.

Reproduction Steps

does not apply

Possible Solution

No response

Additional Information/Context

This seems to only happen for the ace-builds releases. The files inside the ace repo, the tar release of these files, only have ace-1.39.0/demo/kitchen-sink/docs/haxe.hx

Ace Version / Browser / OS / Keyboard layout

1.37.1, 1.39.0

@marinsokol5
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants