test(coverage): Add comprehensive test coverage for auto_implement_git_integration.py (1,784 lines, 0% → 60%)

[akaszubski]

Summary

Add comprehensive test coverage for auto_implement_git_integration.py (1,791 lines), increasing from current partial state to 60% baseline. Module handles critical git automation workflows. Current test file exists (1,079 lines, 86 tests) but has 18 failing tests and missing coverage for core integration functions.

What Does NOT Work

Failing Test Patterns (18 test failures):

1. Consent defaults behavior - Tests expect False but implementation defaults to True
2. Security validation mocking - Mock doesn't match CalledProcessError signature
3. Missing coverage for integration functions:
   • create_commit_with_agent_message() (133 lines) - 0%
   • push_and_create_pr() (150 lines) - 0%
   • execute_git_workflow() (71 lines) - 0%
   • execute_step8_git_operations() (201 lines) - 0%

Scenarios

Fresh Install

• Run pytest: 86 tests, 18 failures, coverage warnings
• Expect: Tests pass, 60%+ coverage

Update/Upgrade

• Existing: 68 passing tests preserved
• Fix: 18 failing tests updated
• Add: 32 new tests for uncovered functions

Implementation Approach

Phase 1: Fix Failing Tests (15% coverage, ~2h)

Update consent default expectations and security mocks

Phase 2: Add Security Validation Tests (35% coverage, ~3h)

• TestValidateGitState (12 tests)
• TestValidateBranchName (10 tests) - CWE-78, CWE-22
• TestValidateCommitMessage (10 tests) - CWE-117

Phase 3: Add Integration Tests (60% coverage, ~5h)

• TestCreateCommitWithAgentMessage (15 tests)
• TestPushAndCreatePR (15 tests)
• TestExecuteGitWorkflow (10 tests)

Test Scenarios

• Fresh install: all tests pass, 60%+ coverage
• Update: preserve 68 passing tests
• Subprocess mock failures handled correctly
• Security validation blocks command injection
• Integration error propagation works
• Rollback after push failure

Acceptance Criteria

Fresh Install

• All tests pass (0 failures)
• Coverage ≥60% for auto_implement_git_integration.py
• Test execution <30s

Updates

• 68 existing tests still pass
• 18 failing tests fixed
• 32 new tests added
• Total: 118+ tests

Security

• CWE-78: Command injection tests
• CWE-22: Path traversal tests
• CWE-117: Log injection tests
• All git operations mocked

Security Considerations

CWE-78: OS Command Injection

• Block $(command), command, ; | & $ metacharacters
• Tests: validate_branch_name(), validate_commit_message()

CWE-22: Path Traversal

• Block ../../../ sequences
• Tests: validate_branch_name()

CWE-117: Log Injection

• Allow multi-line (valid), block ANSI/carriage returns
• Tests: validate_commit_message()

Source of Truth

Audit: 2026-01-26 Phase 2a
Coverage: Currently partial (86 tests, 18 failures)
Module: 1,791 lines (5th largest, high risk)
Related: #269 (Phase 2 tracking), #234 (Phase 1 coverage), #61 (consent model)

CWE References:

• CWE-78: https://cwe.mitre.org/data/definitions/78.html
• CWE-22: https://cwe.mitre.org/data/definitions/22.html
• CWE-117: https://cwe.mitre.org/data/definitions/117.html

---

Part of: Issue #269 (Phase 2a - Test Coverage)
Priority: P0 (Highest risk module)
Target: 60% baseline coverage

[akaszubski]

Implemented in PR #324 (batch-20260205-233714)