Batch mode doesn't auto-close GitHub issues after successful implementation

[akaszubski]

Summary

When batch processing completes successfully via /implement --issues, the GitHub issues are not automatically closed. The user has to manually close them after the batch completes.

What Does NOT Work

Pattern that FAILS: Batch completion without issue closure

• Batch implements all features successfully
• Commits are created with issue references
• Merge to main completes
• Push to origin completes
• Issues remain OPEN - user must manually run gh issue close

Expected Behavior

After a successful batch implementation:

1. Each issue should be closed when its implementation commit is created
2. OR all issues should be closed after successful merge to main
3. Close comment should reference the commit hash

Implementation Approach

Add to auto_git_workflow.py or create new batch_issue_closer.py:

def close_batch_issues(batch_state: dict, merge_commit: str):
    """Close all issues in batch after successful merge."""
    for feature in batch_state['completed_features']:
        if 'issue' in feature:
            subprocess.run([
                'gh', 'issue', 'close', str(feature['issue']),
                '--comment', f'Implemented in {merge_commit}'
            ])

Related

• Issue Worktree batch processing fails with ModuleNotFoundError - venv not available in worktrees #320 (worktree venv)
• Issue /sync command fails with circular import - sync_dispatcher package not installed #321 (sync circular import)

[akaszubski]

Research Findings from Batch Run

PR #324 implements 12 features via batch mode and demonstrates this bug:

• All 12 features completed successfully
• No auto-commit, push, or issue close occurred
• Manual intervention was required

Root Cause Analysis

The infrastructure exists but is disconnected from the batch loop:

What exists:

• execute_git_workflow() in auto_implement_git_integration.py - handles commit/push/PR
• record_git_operation() for tracking operations
• batch_issue_closer.py for closing issues
• in_batch_mode parameter support throughout

What's missing:
The batch loop in /implement --issues never calls execute_git_workflow(in_batch_mode=True) after completing each feature. The loop processes features but doesn't trigger the git automation.

Fix Location

The fix should be in the /implement command's batch processing logic:

# After each feature completes successfully:
if batch_mode and feature_completed:
    execute_git_workflow(
        in_batch_mode=True,
        issue_number=current_issue,
        commit_message=f"feat: implement #{current_issue}"
    )

Evidence

• Batch state shows all 12 features completed: .worktrees/batch-20260205-233714/.claude/batch_state.json
• No git operations were recorded during batch run
• Manual commit/push/PR was required after batch completed

Related PR: #324 (12 features from this batch run)

[akaszubski]

Evidence from Batch Run batch-20260205-233714

PR #324 demonstrates this bug in action:

• 12 issues processed (311, 310, 309, 308, 307, 306, 305, 304, 302, 278, 270, 269)
• All completed successfully
• None auto-closed - all remain open

Root Cause Analysis

The infrastructure exists but is never called:

1. execute_git_workflow() exists in auto_implement_git_integration.py:780+

   • Has in_batch_mode parameter
   • Supports per-feature commits with gh issue close

2. Batch loop never calls it - The batch processing loop in /implement --issues completes features but doesn't invoke git automation

3. Evidence: batch_state.json shows:

{
  "completed_features": [12 features...],
  "git_operations": {}  // <-- Empty!
}

Fix Location

The batch loop (in skill or orchestrator) needs to call:

execute_git_workflow(
    session_state=state,
    in_batch_mode=True,
    issue_number=feature['issue']
)

After each feature completes OR after all features complete (bulk close).

Related Issues

• Batch mode permission prompts not suppressed - MCP_AUTO_APPROVE not propagating to subagents #323: MCP_AUTO_APPROVE propagation (permission prompts block automation)

[akaszubski]

Implemented in commit a26ce86 on branch batch-issues-322-323-325.

Added auto-close GitHub issues integration:

• Lazy import for batch_issue_closer to avoid circular dependencies
• Integration in update_batch_progress() to call close_batch_feature_issue() after feature completion
• Graceful degradation if issue closing fails
• Added 4 tests for the integration