[CI] [HOOK-REGRESSION] #944 stripped conversation_archiver Stop hook from settings.granular-bash.json template

[akaszubski]

Problem

Issue #944 (strip global hook duplicates from per-repo settings templates) incorrectly stripped the `conversation_archiver` Stop hook from `plugins/autonomous-dev/templates/settings.granular-bash.json`. The hook is present in the main repo but absent in the batch worktree after #944 ran.

This causes the regression test `test_conversation_archiver.py::TestHookRegistration::test_hook_in_all_settings_templates` to fail.

Repo: autonomous-dev
Session: 2026-04-25T11:44 - 13:23 (batch-20260425-214020)

Evidence

Main repo settings.granular-bash.json Stop hooks (2 entries):

1. session_activity_logger.py
2. CONVERSATION_ARCHIVE=true ... conversation_archiver.py

Worktree after #944:

1. session_activity_logger.py
2. (MISSING) conversation_archiver entry was stripped

Failure:

FAILED tests/unit/hooks/test_conversation_archiver.py::TestHookRegistration::test_hook_in_all_settings_templates
AssertionError: conversation_archiver not found in settings.granular-bash.json Stop hooks

Hook test suite: 6 failures in worktree vs 0 failures in main repo HEAD.

Root Cause

The strip_global_duplicates() function added by #944 incorrectly identified conversation_archiver as a "global duplicate" in the granular-bash template and removed it. The conversation_archiver entry in granular-bash is intentionally present — it is a per-mode hook, not a global duplicate.

Suggested Fix

1. Audit CANONICAL_GLOBAL_HOOKS set in settings_merger.py — ensure it does NOT include conversation_archiver
2. Add regression test: strip_global_duplicates on granular-bash template MUST preserve conversation_archiver entry
3. Re-run strip on the granular-bash template to restore the missing hook

Plugin Version: PLUGIN_VER_PLACEHOLDER

---

Filed automatically by continuous-improvement-analyst

[akaszubski]

Still failing after #971 session (2026-04-26)

Session: c29a5b5d | RUN_ID: 20260426-203837

Hook test suite ran post-implementation: `1 failed, 1625 passed, 3 skipped`

The `test_conversation_archiver.py::TestHookRegistration::test_hook_in_all_settings_templates` failure persists. Confirmed that `plugins/autonomous-dev/config/settings.granular-bash.json` has zero Stop hooks (conversation_archiver is absent).

This was not caused by the #971 changes (no modifications to `settings.granular-bash.json` or `test_conversation_archiver.py` in this session). Pre-existing failure count is confirmed at 1 total (not the 8 from batch_permission_approver noted in the CIA system prompt — batch_permission_approver tests are passing).

Noted by continuous-improvement-analyst, pipeline #971

[akaszubski]

Confirmed still failing as of 2026-04-27 (post-#970 session). Hook test suite run result:

FAILED tests/unit/hooks/test_conversation_archiver.py::TestHookRegistration::test_hook_in_all_settings_templates - AssertionError: conversation_archiver not found in settings.granular-bash.json Stop hooks
1 failed, 1625 passed, 3 skipped

This was the only hook regression detected in the #970 pipeline run. All 24 other hook tests pass. Issue pre-dates #970 and was not introduced by it.

Session: c29a5b5d-037b-4ee9-8c25-ca4aec52071d

[akaszubski]

Confirmed still failing post-#972 (WAVE 1 capstone). Test result from session 2026-04-26:

FAILED tests/unit/hooks/test_conversation_archiver.py::TestHookRegistration::test_hook_in_all_settings_templates
AssertionError: conversation_archiver not found in settings.granular-bash.json Stop hooks

Run output: 1 failed, 1625 passed, 3 skipped — not pre-existing in the known-8 baseline (the known pre-existing failures are all in batch_permission_approver). This is a NEW regression.

#972 did not fix this because it was focused on hook composition telemetry (#942 scope). Needs a dedicated fix.

Noted by continuous-improvement-analyst — session c29a5b5d, #972 WAVE 1 capstone run

[akaszubski]

Hook test suite check for run 20260508-212809: 1 failure, 1653 passed, 3 skipped.

The single failure is test_hook_in_all_settings_templates — conversation_archiver not found in settings.granular-bash.json Stop hooks. This is the same failure tracked by this issue — pre-existing, not a new regression introduced by the 20260508 refactor. Confirming the known-failure baseline for this run: 1 failure (this issue), not the 8 batch_permission_approver failures.

The known pre-existing failure count for this repo's hook test suite is currently 1 (this issue), not 8. The system instructions reference "8 = 8 total" from batch_permission_approver — that count may be stale or from a different configuration.

[akaszubski]

False positive — already addressed by commit 1a94584 (#1085): "correct over-broad test_hook_in_all_settings_templates assertion". The conversation_archiver hook is correctly global-only per Issue #944 design intent; per-repo granular-bash template intentionally omits it. The over-broad test was narrowed in #1085 to only check global_settings_template.json (which DOES contain conversation_archiver). Verified: test_hook_in_global_settings_template passes, hook test suite passes.