Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate method should throw illegal state exception instead of Null Pointer Exception #13

Open
GoogleCodeExporter opened this issue Apr 20, 2015 · 0 comments
Open

Validate method should throw illegal state exception instead of Null Pointer Exception #13

GoogleCodeExporter opened this issue Apr 20, 2015 · 0 comments
Labels
auto-migrated Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 

As per Effective Java, builder should throw IllegalStateException if trying to 
build a DTO without all required valid  properties. Also, conceptually speaking 
it makes more sense to throw this exception instead of NPE.

Implementation should be just to replace checkNotNull method with checkState 
methods.

Original issue reported on code.google.com by [email protected] on 21 Sep 2014 at 6:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter