Skip to content

Fix authentication errors for passwords with special characters #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurdyukov merged 1 commit into from
Dec 6, 2024
Merged

Fix authentication errors for passwords with special characters #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tap_clickhouse/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from __future__ import annotations

from typing import Any, Iterable
from urllib.parse import quote

import sqlalchemy # noqa: TCH002
from singer_sdk import SQLConnector, SQLStream
Expand Down Expand Up @@ -37,7 +38,7 @@ def get_sqlalchemy_url(self, config: dict) -> str:
else:
secure_options = f"secure={config['secure']}&verify={config['verify']}"
return (
f"clickhouse+{config['driver']}://{config['username']}:{config['password']}@"
f"clickhouse+{config['driver']}://{quote(config['username'])}:{quote(config['password'])}@"
f"{config['host']}:{config['port']}/"
f"{config['database']}?{secure_options}"
)
Expand Down