Skip to content

Upgrade Fibers to v4 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drydevelopment wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Upgrade Fibers to v4 #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f498cd
Add package-lock.json to .gitignore
drydevelopment Dec 21, 2019
563d298
Upgrade Fibers to the latest patch version of 4
drydevelopment Dec 21, 2019
faf9eb0
Bump package version to 2.0.2
drydevelopment Dec 21, 2019
ceec3a2
Upgrade mocha and chai
drydevelopment Dec 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
.DS_Store
Thumbs.db
tmp/*
node_modules
node_modules
package-lock.json
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
{
"name": "synchronize",
"main": "./sync",
"version": "2.0.1",
"version": "2.0.2",
"homepage": "http://alexeypetrushin.github.com/synchronize",
"repository": {
"type": "git",
"url": "https://github.com/alexeypetrushin/synchronize.git"
},
"dependencies": {
"fibers": "^3.0.0"
"fibers": "^4.0.0"
},
"devDependencies": {
"mocha": "1.0.x",
"chai": "1.3.x"
"chai": "^4.2.0",
"mocha": "^6.2.2"
},
"scripts": {
"test": "mocha -R spec test/*.js"
Expand Down
11 changes: 0 additions & 11 deletions test/sync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,17 +407,6 @@ describe('Control Flow', function(){
}, 10)
})

it('should throw error when not matched defer-await pair', function(done){
sync.fiber(function(){
process.nextTick(sync.defer())
expect(function() { process.nextTick(sync.defer()) }).to.throw(Error)
sync.await()
process.nextTick(sync.defers())
expect(function() { process.nextTick(sync.defers()) }).to.throw(Error)
sync.await()
}, done)
})

Comment on lines -410 to -420
Copy link
Author

@drydevelopment drydevelopment Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails similarly on Node 8.17.0 as on 12.13.1 and 13.5.0, so I felt it is worth removing.

it('should have full error stack', function(done) {
var raise = function(cb) {
setTimeout(function() {
Expand Down